Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added "Scroll Down Progress Bar" To The website #666

Merged
merged 11 commits into from
Jul 5, 2024

Conversation

MastanSayyad
Copy link
Contributor

@MastanSayyad MastanSayyad commented Jun 22, 2024

Description

Hey @Anishkagupta04 and @varshith257 | issue closes #659

I have added the Scroll down progress bar in All pages of the website

image

rapidoc.mp4

Type of PR

  • Feature enhancement

Checklist

  • I have gone through the contributing guide
  • I have updated my branch and synced it with project main branch before making this PR
  • I have performed a self-review of my code
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have commented my code, particularly in hard-to-understand areas.

Additional context:

Please take a look and review it, Thank You!!

Copy link

vercel bot commented Jun 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rapidoc ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 5, 2024 4:57am

Copy link

netlify bot commented Jun 22, 2024

Deploy Preview for rapidoc ready!

Name Link
🔨 Latest commit d3e64fa
🔍 Latest deploy log https://app.netlify.com/sites/rapidoc/deploys/66877d3dc7d5a6000866d0db
😎 Deploy Preview https://deploy-preview-666--rapidoc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @MastanSayyad! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project.We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

@MastanSayyad
Copy link
Contributor Author

@varshith257 please review this PR

@MastanSayyad
Copy link
Contributor Author

Hey @Anishkagupta04 and @varshith257 please take a look at this PR

@MastanSayyad
Copy link
Contributor Author

@varshith257 I have resolved the conflicts pls merge this PR

@MastanSayyad
Copy link
Contributor Author

@Anishkagupta04 @varshith257 I I have resolve the conflicts again pls merge this PR

@MastanSayyad
Copy link
Contributor Author

@varshith257 I have resolved the conflicts pls merge this

@varshith257
Copy link
Collaborator

@MastanSayyad Navbar has disappeared with the scrollbar.Have a look onto it

@MastanSayyad
Copy link
Contributor Author

@varshith257

Sorry for the oversight it may have gotten broken while resolving the conflicts!!
thank you for letting me know, I have fixed that!! Please take a look and review it!

@varshith257
Copy link
Collaborator

Awarding level 3 for extending Progress bar to other pages too

@varshith257 varshith257 added the level3 hard (new feature) label Jul 5, 2024
@varshith257 varshith257 merged commit 0e70c48 into Anishkagupta04:main Jul 5, 2024
7 checks passed
Copy link
Contributor

github-actions bot commented Jul 5, 2024

🎉 Your pull request has been successfully merged! 🎉 Thank you for your contribution to our project. Your efforts are greatly appreciated. Keep up the fantastic work! 🚀

@varshith257
Copy link
Collaborator

@MastanSayyad
Can raise an issue for this, I feel it is misaligned and an area for improvement:

image

@varshith257
Copy link
Collaborator

And also the same for appointment form section

@MastanSayyad
Copy link
Contributor Author

@MastanSayyad Can raise an issue for this, I feel it is misaligned and an area for improvement:

Sure, I have raised the issue for it!

@MastanSayyad
Copy link
Contributor Author

Awarding level 3 for extending Progress bar to other pages too

Thank you for the consideration, really appreciated!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc level3 hard (new feature)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ Feature: Add "Scroll Down Progress Bar" To The website
2 participants