Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Doctor Experience.html #564

Closed
wants to merge 3 commits into from

Conversation

ankitmodanwall
Copy link

@ankitmodanwall ankitmodanwall commented Jun 14, 2024

I added some useful fonts with footer, header

style that enhance the looks than before.

Description

Since this page doesn't contain as such impressive footer along with data and about section so that i made changes.

Related Issues

  • Footer section at below the page

  • Style tag

  • text-align

  • Closes #

Type of PR

  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): _______________

Screenshots / videos (if applicable)

now you can relate this updated page

Checklist

Screenshot 2024-06-14 061618

  • I have gone through the contributing guide
  • I have updated my branch and synced it with project main branch before making this PR
  • I have performed a self-review of my code
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have commented my code, particularly in hard-to-understand areas.

I added some useful fonts with footer, header <h1> style that enhance the looks than before.
Copy link

vercel bot commented Jun 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rapidoc ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 16, 2024 0:49am

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @ankitmodanwall! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project.We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

Copy link

netlify bot commented Jun 14, 2024

Deploy Preview for rapidoc ready!

Name Link
🔨 Latest commit c01b36a
🔍 Latest deploy log https://app.netlify.com/sites/rapidoc/deploys/666edf334bcd9d00080675d7
😎 Deploy Preview https://deploy-preview-564--rapidoc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ankitmodanwall
Copy link
Author

Thank you!!

@Anishkagupta04
Copy link
Owner

send ss of the changes

@varshith257
Copy link
Collaborator

@ankitmodanwall Resolve conflicts

@ankitmodanwall
Copy link
Author

ankitmodanwall commented Jun 16, 2024

@varshith257
now conflict has resolved.

@ankitmodanwall
Copy link
Author

@Anishkagupta04
I made few changes as

  • background palette added
  • update social medias logo
  • added black heart as compare to red heart
  • about section consists of italic font

##Screen-shots
Screenshot 2024-06-16 182033

Screenshot 2024-06-16 182017

@varshith257
Copy link
Collaborator

@ankitmodanwall Closing. LATEST upstream footer is better

@ankitmodanwall
Copy link
Author

@varshith257 so what did you mean ?

@varshith257
Copy link
Collaborator

The current footer satisfies the requirements and there is no assigned issues to this PR too and color Schema is not aligned with Project

@ankitmodanwall
Copy link
Author

Could you share the ss?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants