Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added the "medicine use" page #518

Merged
merged 8 commits into from
Jul 3, 2024
Merged

Conversation

samarsajad
Copy link
Contributor

Description

The "medicine use" now redirects to medicine.html that fetches data from FDA API and provides the information for medicines

Related Issues

[Cite any related issue(s) this pull request addresses. If none, simply state “None”]

Type of PR

  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): _______________

Screenshots / videos (if applicable)

image

Checklist

  • I have gone through the contributing guide
  • I have updated my branch and synced it with project main branch before making this PR
  • I have performed a self-review of my code
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have commented my code, particularly in hard-to-understand areas.

Additional context:

GSSoC'24

Copy link

vercel bot commented Jun 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rapidoc ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 25, 2024 4:59pm

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @samarsajad! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project.We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

@samarsajad
Copy link
Contributor Author

Please review my pull request @varshith257 @Anishkagupta04

@Anishkagupta04
Copy link
Owner

try making more attracted also footer text colour is not going with website

@varshith257
Copy link
Collaborator

@samarsajad Make colors consistent with what is already using in the project. Also why can't you try to put I'm ages related to medicines instead logo in the med page

@samarsajad
Copy link
Contributor Author

samarsajad commented Jun 11, 2024

You said I can raise multiple issues later, so I just created a basic framework for now . I focused on functionality in this PR @varshith257

@varshith257
Copy link
Collaborator

Try to make little consistent with colors

@samarsajad
Copy link
Contributor Author

samarsajad commented Jun 11, 2024

Try to make little consistent with colors

Should I Ichange the footer? cause everything else is consistent with the website design? @varshith257

Copy link

netlify bot commented Jun 11, 2024

Deploy Preview for rapidoc ready!

Name Link
🔨 Latest commit c0b027e
🔍 Latest deploy log https://app.netlify.com/sites/rapidoc/deploys/667af77a4506130008d9e06f
😎 Deploy Preview https://deploy-preview-518--rapidoc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@samarsajad
Copy link
Contributor Author

I made the changes. Made the footer consistent with the theme of the overall website @varshith257 @Anishkagupta04

@samarsajad
Copy link
Contributor Author

samarsajad commented Jun 14, 2024

heyy. can you please take a look @Anishkagupta04 @varshith257

@samarsajad
Copy link
Contributor Author

Can you please review this pull request so that I can further work on enhancing this page @varshith257

@varshith257
Copy link
Collaborator

@samarsajad The page is not clickable on medical use on home page. PTAL

@samarsajad
Copy link
Contributor Author

samarsajad commented Jun 16, 2024

I made the chnages . can you please take a look again and see if it is working now @varshith257 @Anishkagupta04

@samarsajad
Copy link
Contributor Author

Can you please take a look @varshith257

@samarsajad
Copy link
Contributor Author

Can you please take a look @Anishkagupta04 @varshith257 . I checked the deploy preview and it is working as expected

deploycheck.mp4

@samarsajad
Copy link
Contributor Author

Please review my pull request. I made all the changes as requested and also posted the deploy preview . @varshith257 @Anishkagupta04

@varshith257
Copy link
Collaborator

@Anishkagupta04 Have a look and merge this

@samarsajad
Copy link
Contributor Author

@Anishkagupta04 Have a look and merge this

please look into this @Anishkagupta04 @varshith257

@varshith257 varshith257 added gssoc level3 hard (new feature) labels Jul 3, 2024
@varshith257 varshith257 merged commit 56f8513 into Anishkagupta04:main Jul 3, 2024
8 checks passed
Copy link
Contributor

github-actions bot commented Jul 3, 2024

🎉 Your pull request has been successfully merged! 🎉 Thank you for your contribution to our project. Your efforts are greatly appreciated. Keep up the fantastic work! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc level3 hard (new feature)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨[Feature Request]: Build the "Medicine Use" page
3 participants