Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Animated icon in Navbar and Footer links #469

Closed
wants to merge 8 commits into from
Closed

Added Animated icon in Navbar and Footer links #469

wants to merge 8 commits into from

Conversation

SadafKausar2025
Copy link

@SadafKausar2025 SadafKausar2025 commented Jun 7, 2024

Description

[Please include a brief description of the changes or features added]

Related Issues #466

[Cite any related issue(s) this pull request addresses. If none, simply state “None”]

Type of PR

  • Feature enhancement

before

Screenshot (1939)

after

Screenshot (1941)

Screenshot (1943)

Checklist

  • I have gone through the contributing guide
  • I have updated my branch and synced it with project main branch before making this PR
  • I have performed a self-review of my code
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have commented my code, particularly in hard-to-understand areas.

Additional context:

[Include any additional information or context that might be helpful for reviewers.]

Copy link

vercel bot commented Jun 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rapidoc ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 11, 2024 4:11am

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @SadafKausar2025! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project.We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

@SadafKausar2025
Copy link
Author

Hello @Anishkagupta04
please review this PR and merge it

@varshith257
Copy link
Collaborator

@SadafKausar2025 I think there is no need for the icons in footer

@SadafKausar2025
Copy link
Author

Screenshot (1958)

@SadafKausar2025
Copy link
Author

hello @varshith257
I have removed icons from footer .
please review this PR and merge it

@varshith257
Copy link
Collaborator

Will review soon. I am viewing it in mobile so unable to find why lot of code has been deleted in PR

@SadafKausar2025
Copy link
Author

I have also fixed the subscribe button which was not align properly before

Screenshot (1959)

@SadafKausar2025
Copy link
Author

footer icons codes are deleted

@SadafKausar2025
Copy link
Author

@varshith257
yes footer links code are deleted

@SadafKausar2025
Copy link
Author

hello @varshith257 and @Anishkagupta04
I have resolved the conflict please merge my PR

@Anishkagupta04
Copy link
Owner

pleassee look into the footer its orientation is dismantle

@SadafKausar2025
Copy link
Author

pleassee look into the footer its orientation is dismantle

yes checking

@SadafKausar2025
Copy link
Author

hello @Anishkagupta04
please check now Is it correct?

@SadafKausar2025
Copy link
Author

hello @varshith257 and @Anishkagupta04
I have resolved the conflict
please merge it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨[Feature Request]: Adding Animated icons in Footer and Navbar links
3 participants