Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blood test page added #432

Closed
wants to merge 1 commit into from
Closed

Conversation

samarsajad
Copy link
Contributor

Fixes #365

Description

Created a blood test page where the user can book for the tests

Related Issues

Type of PR

  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): _______________

Screenshots / videos (if applicable)

test.page.mp4

Checklist

  • I have gone through the contributing guide
  • I have updated my branch and synced it with project main branch before making this PR
  • I have performed a self-review of my code
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have commented my code, particularly in hard-to-understand areas.

Additional context:

GSSoC'24

Copy link

vercel bot commented Jun 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rapidoc ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 4, 2024 6:58pm

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @samarsajad! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project.We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

@samarsajad
Copy link
Contributor Author

Please review my pull request @Anishkagupta04 @varshith257

@Anishkagupta04
Copy link
Owner

The alignment is not proper

@samarsajad
Copy link
Contributor Author

samarsajad commented Jun 5, 2024

can you please explain what changes you want me to do ? @Anishkagupta04 @varshith257

@varshith257
Copy link
Collaborator

@Anishkagupta04 Suggest the changes required

@samarsajad
Copy link
Contributor Author

@Anishkagupta04 Suggest the changes required

Can you please specify the changes? It'd be really helpful if you suggest what all to fix in the webpage and what sort of alignment you want me to keep @varshith257 @Anishkagupta04

@varshith257
Copy link
Collaborator

Hah, the issue is that it looks like a column page and you can create it as a separate page and keep it as a form for blood test details.

Something you can take reference from this article:
https://medium.com/@pawankumar/ui-ux-case-study-redefined-test-booking-experience-by-following-the-design-thinking-process-be2ac6a1b805

You can submit multiple PRs for features and pages you add for the complete blood test feature for this project as mentioned in above article, we assign labels each for them separately

@samarsajad
Copy link
Contributor Author

samarsajad commented Jun 6, 2024

Well it is a separate page and is a form for the blood test page . I thought that's what the blood test should lead to @varshith257

@varshith257
Copy link
Collaborator

Better follow the referenced article

@samarsajad
Copy link
Contributor Author

I did the required changes and created a new pull request. Please take a look #486 @Anishkagupta04 @varshith257

@samarsajad samarsajad closed this Jun 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨[Feature Request]: Blood Test Page
3 participants