Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated header markup to remove 'd-none' class from 'EMERGENCY' span #336

Merged
merged 1 commit into from
May 27, 2024

Conversation

TARUN2K3
Copy link
Contributor

Description

Removed the 'd-none' class from the 'EMERGENCY' span within the header section to ensure the text is visible. The 'd-none' class was replaced with the 'd-md-inline' class to maintain responsive behavior, displaying the text on medium and larger screens while hiding it on smaller screens.

Related Issues

Type of PR

  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): _______________

Screenshots / videos (if applicable)

Before:

image

After:

image

Checklist

  • I have gone through the contributing guide
  • I have updated my branch and synced it with project main branch before making this PR
  • I have performed a self-review of my code
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have commented my code, particularly in hard-to-understand areas.

Additional context:

-Complies with accessibility best practices by making all features available to users with disabilities who might rely on responsive design features or use assistive technologies.
-Mobile and tablet users constitute a significant portion of web traffic. By making the Emergence button visible in responsive mode, the application becomes more accessible to this demographic, potentially increasing user engagement and retention.

Removed the 'd-none' class from the 'EMERGENCY' span within the header section to ensure the text is visible. The 'd-none' class was replaced with the 'd-md-inline' class to maintain responsive behavior, displaying the text on medium and larger screens while hiding it on smaller screens.
@varshith257 varshith257 added gssoc level1 easy (bug, documentaion) labels May 27, 2024
@TARUN2K3
Copy link
Contributor Author

@varshith257
The changes in this pull request are now ready for merging into the main branch. I've thoroughly tested the changes to ensure they integrate smoothly with the existing codebase.

@varshith257 varshith257 merged commit 1ffd94d into Anishkagupta04:main May 27, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc level1 easy (bug, documentaion)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨[Feature Request]: Emergence button is not visible in responsive mode
2 participants