Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added more restrictions to Phone number and Calendar feature #296

Merged
merged 7 commits into from
May 26, 2024

Conversation

kesharwaniyanshi
Copy link
Contributor

Description

Earlier the phone number could accept anything alphabet,symbol etc and any length number . Now i have fixed that and also updated the Appointment date section .Added calendar to it for better user experience.

Related Issues

Type of PR

  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): _______________

Screenshots / videos (if applicable)

[Attach any relevant screenshots or videos demonstrating the changes]
image
image
image
image

Checklist

  • I have gone through the contributing guide
  • I have updated my branch and synced it with project main branch before making this PR
  • I have performed a self-review of my code
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have commented my code, particularly in hard-to-understand areas.

@varshith257
Copy link
Collaborator

varshith257 commented May 25, 2024

@kesharwaniyanshi I think it's better intuitive if we add strict validation of format of mobile number along with country codes and validation of phone number

@varshith257 varshith257 added enhancement New feature or request gssoc level2 medium (enhancements) labels May 25, 2024
@kesharwaniyanshi
Copy link
Contributor Author

@kesharwaniyanshi I think it's better intuitive if we add strict validation of format of mobile number along with country codes and validation of phone number

So do you want me to modify it and make it in a format that it accepts country codes as well?

@kesharwaniyanshi
Copy link
Contributor Author

image
I made required changes kindly have a look and merge my PR.

@varshith257
Copy link
Collaborator

Can't see any changes over there in the files?

@kesharwaniyanshi
Copy link
Contributor Author

Can't see any changes over there in the files?

image
image
I have added a js code for country code and made some css modifications and additions to adjust it properly

index.html Dismissed Show dismissed Hide dismissed
@varshith257 varshith257 merged commit f1d9505 into Anishkagupta04:main May 26, 2024
3 checks passed
@varshith257
Copy link
Collaborator

@kesharwaniyanshi Thanks for the contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request gssoc level2 medium (enhancements)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨[Feature Request]: Improving the Make Appointments Section
2 participants