Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Navigation bar #138 #173

Merged
merged 5 commits into from
May 17, 2024
Merged

Conversation

ShahHetviIT
Copy link
Contributor

@ShahHetviIT ShahHetviIT commented May 16, 2024

image

PR Description

Improvement in navigation bar.
if any problem kindly explain to me i will solve it. I have tried my best to improve this

Related Issues: Issue for which you are raising a PR for

Improve Navigation bar #138

  • Closes #

Issue

Improve Navigation bar #138

Checklist

  • I have gone through the [contributing guide](## PR Description

Add your description

Related Issues: Issue for which you are raising a PR for

  • Closes #

Issue

Improve Navigation bar #138

Checklist

  • I have gone through the contributing guide
  • I have updated my branch and synced it with project main branch before making this PR
  • Is this a bug fix/enhancement/documentation changes

Undertaking

I declare that:

  1. The content I am submitting is original and has not been plagiarized.
  2. No portion of the work has been copied from any other source without proper attribution.
  3. The work has been checked for plagiarism, and I assure its authenticity.
  • I have updated my branch and synced it with project main branch before making this PR
  • Is this a bug fix/enhancement/documentation changes
  • Part of GSSOC
  • Tested for any breaking changes
  • Other relevant checks completed

I understand that any violation of this undertaking may have legal consequences that I will bear and could result in the withdrawal of any recognition associated with the work.

  • I Agree

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to Our repository.🎊 Thank you so much for taking the time to point this out.

@varshith257
Copy link
Collaborator

@ShahHetviIT Can you add some alignment gap between the image and text in nav bar. Ex: Home image and it's text a little bit of 0.5px. Except this everything is fine

@ShahHetviIT
Copy link
Contributor Author

yes sure i will do

@ShahHetviIT
Copy link
Contributor Author

i have added 4 px gap as it looks nice. Tell me if more changes needed

@varshith257
Copy link
Collaborator

Can send updated navbar pic?

@ShahHetviIT
Copy link
Contributor Author

ShahHetviIT commented May 17, 2024

image

@ShahHetviIT
Copy link
Contributor Author

Any changes needed?

@varshith257 varshith257 linked an issue May 17, 2024 that may be closed by this pull request
@varshith257 varshith257 added enhancement New feature or request gssoc level1 easy (bug, documentaion) labels May 17, 2024
@varshith257 varshith257 merged commit bb2dde6 into Anishkagupta04:main May 17, 2024
1 check passed
@varshith257
Copy link
Collaborator

@ShahHetviIT Thanks for the contribution 🚀

@ShahHetviIT
Copy link
Contributor Author

Thanks for give me opportunity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request gssoc level1 easy (bug, documentaion)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

💡[FEATURE]: Improve Navigation bar
2 participants