Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

created separate page for services #1179

Merged

Conversation

aditya-bhaumik
Copy link
Contributor

Description

Related Issues

Type of PR

  • ()

Screenshots / videos (if applicable)

Checklist

  • I have gone through the contributing guide
  • I have updated my branch and synced it with project main branch before making this PR
  • I have performed a self-review of my code
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have commented my code, particularly in hard-to-understand areas.

Additional context:

image

Copy link

vercel bot commented Aug 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rapidoc ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 10, 2024 0:40am

Copy link

netlify bot commented Aug 10, 2024

Deploy Preview for rapidoc ready!

Name Link
🔨 Latest commit 72cd458
🔍 Latest deploy log https://app.netlify.com/sites/rapidoc/deploys/66b75f9887fd060008aba3a0
😎 Deploy Preview https://deploy-preview-1179--rapidoc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @aditya-bhaumik! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project.We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

Copy link
Contributor Author

@aditya-bhaumik aditya-bhaumik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@varshith257 please review and merge this pull request as only 8 hours are left for gssoc to get over

Html-Files/services.html Fixed Show fixed Hide fixed
@varshith257
Copy link
Collaborator

@aditya-bhaumik Where this page have been linked in home page? I can also see existing page for services. Ok leave it apart

Also move css to another file

@aditya-bhaumik
Copy link
Contributor Author

aditya-bhaumik commented Aug 10, 2024

@varshith257 okay then instead of creating another services page i will just add this services section to the existing services page i think that would be better update

There is a services section in the services page but it is not as good as the main page before it was not linked to the services page only the navbar was

Sorry i had checked the link in the footer thats why i did not see that exisiting services page

Now i checked it and it is saved as dex.html thats why i missed it


<!-- Bootstrap JS and dependencies -->

<script src="https://code.jquery.com/jquery-3.5.1.slim.min.js"></script>

Check warning

Code scanning / CodeQL

Inclusion of functionality from an untrusted source Medium

Script loaded from content delivery network with no integrity check.
@aditya-bhaumik
Copy link
Contributor Author

@varshith257 i have removed the new page i had made added the services properly to the services page

please review and merge this pull request before 7pm as it is the last time for contributing

@aditya-bhaumik
Copy link
Contributor Author

@varshith257 please merge this pull request only 1 hour is left

@varshith257 varshith257 added gssoc level1 easy (bug, documentaion) labels Aug 10, 2024
@varshith257 varshith257 merged commit df5ac4c into Anishkagupta04:main Aug 10, 2024
9 checks passed
Copy link
Contributor

🎉 Your pull request has been successfully merged! 🎉 Thank you for your contribution to our project. Your efforts are greatly appreciated. Keep up the fantastic work! 🚀

@aditya-bhaumik
Copy link
Contributor Author

@varshith257 thank you this was my last pr for this repo for this program

It was really nice working on this repositionary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc level1 easy (bug, documentaion)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨[Feature Request]: add the services section of main page to the services page
2 participants