Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI of one of the cards does not match with the other cards in the news page . #1115

Merged
merged 3 commits into from
Aug 4, 2024

Conversation

meetarora10
Copy link
Contributor

Description

Changed the UI of the card with different UI and now the cards on the news page have a uniform UI .

Related Issues

Type of PR

  • (Bug Fix)

Screenshots / videos (if applicable)

Screenshot (923)

Checklist

  • I have gone through the contributing guide
  • I have updated my branch and synced it with project main branch before making this PR
  • I have performed a self-review of my code
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have commented my code, particularly in hard-to-understand areas.

Additional context:

I have also removed one extra RAPIDOC white logo which was coming in responsive view .
Screenshot (922)

Copy link

vercel bot commented Aug 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rapidoc ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 4, 2024 6:54pm

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @meetarora10! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project.We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

Copy link

netlify bot commented Aug 2, 2024

Deploy Preview for rapidoc ready!

Name Link
🔨 Latest commit 44d0088
🔍 Latest deploy log https://app.netlify.com/sites/rapidoc/deploys/66afce3f3370dc00087b9ccb
😎 Deploy Preview https://deploy-preview-1115--rapidoc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@meetarora10
Copy link
Contributor Author

@varshith257 please review and merge .

@meetarora10
Copy link
Contributor Author

Hey @varshith257 please have a look .

@meetarora10
Copy link
Contributor Author

@varshith257 not reviewed yet .

@varshith257
Copy link
Collaborator

@meetarora10 I think every card should be green instead the white and also move hover buttons to center of each card

@meetarora10
Copy link
Contributor Author

Ok @varshith257

@meetarora10
Copy link
Contributor Author

Screenshot (973)

@meetarora10
Copy link
Contributor Author

@varshith257 done please review and merge .

@varshith257 varshith257 added gssoc level1 easy (bug, documentaion) labels Aug 4, 2024
@varshith257 varshith257 merged commit b14ac3c into Anishkagupta04:main Aug 4, 2024
8 checks passed
Copy link
Contributor

github-actions bot commented Aug 4, 2024

🎉 Your pull request has been successfully merged! 🎉 Thank you for your contribution to our project. Your efforts are greatly appreciated. Keep up the fantastic work! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc level1 easy (bug, documentaion)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐞[Bug]: UI of one of the cards does not match with the other cards in the news page .
2 participants