Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix variable name m31-ml-variable-rx in andromeda-smie.el #483

Merged
merged 1 commit into from
Dec 19, 2019

Conversation

mikeshulman
Copy link
Contributor

The current m31-meta-variable-rx gives File mode specification error: (void-variable m31-meta-variable-rx). Since m31-ml-variable-rx exists and seems to work, I guessed that it was probably the correct name.

@mikeshulman
Copy link
Contributor Author

(Although now I instead get a whole screen of Warnings from smie.)

@mikeshulman
Copy link
Contributor Author

Huh. I swear this wasn't happening before I submitted the PR, but now with this change (and m31-smart-indent turned on) I get immense slowdowns with a bunch of "looking at" and "fall-through" messages. I guess maybe andromeda-smie doesn't quite work yet. But eri also seems to be broken, so I guess for now I'm going to (remove-hook 'm31-mode-hook 'm31--indentation-setup). I totally understand that #467 is way lower priority than actually writing Andromeda, but I'm curious what you all are using to edit AML code right now?

@andrejbauer
Copy link
Member

I gave up on the SMIE thing, I think @haselwarter hacked on it a while ago. If you turn on OCaml mode it's not so bad. I might create a simple mode based on the OCaml mode that does correct highlighting, a bit like this eff-mode.el. If you have the energy to do it, replace the keywords in eff-mode.el by those listed in parser/lexer.ml and you'll have a simple andromeda-mode.eff. It won't work perfectly (it will get confused by extra end at the end of a match -- that's another debate, whether we should get rid of it).

@andrejbauer
Copy link
Member

The long-term solution is to provide a proof-general interface, of course.

@andrejbauer
Copy link
Member

See #505 for a simple Emacs mode for Andromeda.

@andrejbauer andrejbauer merged commit 8837baa into Andromedans:master Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants