Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include JSON representation of upcoming and past conferences #819

Merged
merged 2 commits into from
Aug 9, 2024

Conversation

ashdavies
Copy link
Contributor

@ashdavies ashdavies commented Aug 6, 2024

Whilst playing with a pet project that would list conferences, I found it would be useful to have this information in JSON format, as the alternative required querying the GitHub API.

Sorry for not accompanying this with a feature request or making an issue first, the implementation turned out to be fairly trivial.

I couldn't figure out how to preserve a line break after a closing bracket though.

Copy link
Contributor

@cortinico cortinico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but want to hear from @cketti as well before we merge this

past.json Outdated Show resolved Hide resolved
past.json Outdated Show resolved Hide resolved
past.json Outdated Show resolved Hide resolved
past.json Outdated Show resolved Hide resolved
past.json Outdated Show resolved Hide resolved
upcoming.json Outdated Show resolved Hide resolved
@ashdavies
Copy link
Contributor Author

Thanks for the comments @cketti, I've applied your suggestions, the JSON looks much better now 👍

Copy link
Contributor

@cketti cketti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

Greetings from Ireland ☘️

@cortinico cortinico merged commit 203253f into AndroidStudyGroup:gh-pages Aug 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants