Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes build for windows with MSVC compiler #14

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vicalejuri
Copy link

Hi Andrew! First, many thanks for your work , it works great! 👏

This pull request fixes compilation errors in the unit tests for windows 10 and Visual Studio 14 2015.

To use the math library in MSVC, the _USE_MATH_DEFINES should be defined.
And also, there was an error in linking the math library, which is actually unnecessary for MSVC.

Additionally, i've included a compilation target for the example

Please let me know if you have problems or if this patch needs more work/refactor.

@codecov-io
Copy link

Codecov Report

Merging #14 into master will decrease coverage by 2.51%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #14      +/-   ##
==========================================
- Coverage   98.95%   96.44%   -2.52%     
==========================================
  Files           3        4       +1     
  Lines         384      394      +10     
==========================================
  Hits          380      380              
- Misses          4       14      +10
Impacted Files Coverage Δ
tests/stableapi_tests.cpp 100% <ø> (ø) ⬆️
examples/demo.c 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2406a22...b320469. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants