Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(internals): implemented turbo watch on dev command #258

Merged
merged 2 commits into from
Sep 22, 2024

Conversation

AndreaPontrandolfo
Copy link
Owner

Fixes #227

Copy link

changeset-bot bot commented Sep 21, 2024

🦋 Changeset detected

Latest commit: e598bd7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
eslint-config-sheriff Patch
@sherifforg/create-config Patch
@sheriff/utils Patch
sheriff-webservices Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Sep 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sheriff ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 21, 2024 6:20pm

@AndreaPontrandolfo AndreaPontrandolfo marked this pull request as ready for review September 21, 2024 18:20
@AndreaPontrandolfo AndreaPontrandolfo merged commit 58e200e into master Sep 22, 2024
4 checks passed
@AndreaPontrandolfo AndreaPontrandolfo deleted the AndreaPontrandolfo/issue227 branch September 22, 2024 14:51
@@ -2,11 +2,10 @@
"name": "sheriff-monorepo",
"private": true,
"scripts": {
"dev": "turbo watch build-watch start",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May I ask why you couldn't just watch build, but needed a new task? Just curious. :)

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lishaduck actually cannot remember. Looking at it now, indeed i dont see much sense for it.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lishaduck actually, after revisioning this, yes, there is a reason for this.
Docs and webservices also have build command, but we dont want to rebuild them in dev, we want to just use the start command on them.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I realized that when I tried to fix it. Turbo did just add a way to do it, though it's not released yet: vercel/turborepo#9339 (comment).

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, to be fair, i stopped using the watch command because it is broken (atleast on my Windows machine). Not sure what the problem is. It's unconvenient, but nothing major, i just have to rebuild the docs manually whenever i change a package.
I'll fix this sometimes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adopt turbo watch
2 participants