Moved deprecated attribute to contracts so that Plugins can use them.…

… Deprecated a few members on window plugin
AndersMalmgren · Mar 22, 2023 · 5f948af · 5f948af
1 parent bed6ded
commit 5f948af
Show file tree

Hide file tree

Showing 5 changed files with 26 additions and 15 deletions.
diff --git a/FreePIE.Core.Contracts/Deprecated.cs b/FreePIE.Core.Contracts/Deprecated.cs
@@ -0,0 +1,15 @@
+using System;
+
+namespace FreePIE.Core.Contracts
+{
+    [AttributeUsage(AttributeTargets.Method | AttributeTargets.Property)]
+    public class Deprecated : Attribute
+    {
+        public string ReplacedWith { get; private set; }
+
+        public Deprecated(string replacedWith)
+        {
+            ReplacedWith = replacedWith;
+        }
+    }
+}
diff --git a/FreePIE.Core.Contracts/FreePIE.Core.Contracts.csproj b/FreePIE.Core.Contracts/FreePIE.Core.Contracts.csproj
@@ -39,6 +39,7 @@
   </ItemGroup>
   <ItemGroup>
     <Compile Include="Attributes.cs" />
+    <Compile Include="Deprecated.cs" />
     <Compile Include="IGlobalNameProvider.cs" />
     <Compile Include="IPlugin.cs" />
     <Compile Include="IPluginProperty.cs" />

diff --git a/FreePIE.Core.Contracts/Properties/AssemblyInfo.cs b/FreePIE.Core.Contracts/Properties/AssemblyInfo.cs
@@ -31,5 +31,5 @@
 // You can specify all the values or you can default the Build and Revision Numbers 
 // by using the '*' as shown below:
 // [assembly: AssemblyVersion("1.0.*")]
-[assembly: AssemblyVersion("1.0.0.0")]
-[assembly: AssemblyFileVersion("1.0.0.0")]
+[assembly: AssemblyVersion("1.1.0.0")]
+[assembly: AssemblyFileVersion("1.1.0.0")]
diff --git a/FreePIE.Core.Plugins/WindowPlugin.cs b/FreePIE.Core.Plugins/WindowPlugin.cs
@@ -100,16 +100,22 @@ public bool isActive(string processName)
             return plugin.IsActive(processName);
         }
 
+        [Deprecated("activate")]
         public bool setActive(string processName)
         {
             return plugin.Activate(processName);
         }
 
-        public string getActive
+        public bool activate(string processName)
         {
-            get { return plugin.GetActiveWindowProcessName(); }
+            return plugin.Activate(processName);
         }
 
+        [Deprecated("active")] public string getActive => active;
+
+        public string active => plugin.GetActiveWindowProcessName();
+
+
         public int pollingInterval
         {
             set { plugin.PollingInterval = value; }

diff --git a/FreePIE.Core/ScriptEngine/Globals/ScriptHelpers/IScriptHelper.cs b/FreePIE.Core/ScriptEngine/Globals/ScriptHelpers/IScriptHelper.cs
@@ -5,16 +5,5 @@ namespace FreePIE.Core.ScriptEngine.Globals.ScriptHelpers
     [AttributeUsage(AttributeTargets.Method)]
     public class NeedIndexer : Attribute { }
 
-    [AttributeUsage(AttributeTargets.Method | AttributeTargets.Property)]
-    public class Deprecated : Attribute
-    {
-        public string ReplacedWith { get; private set; }
-
-        public Deprecated(string replacedWith)
-        {
-            ReplacedWith = replacedWith;
-        }
-    }
-
     public interface IScriptHelper { }
 }