Skip to content
This repository has been archived by the owner on Mar 5, 2020. It is now read-only.

added english character conversion #454

Merged
merged 7 commits into from
Sep 12, 2018
Merged

added english character conversion #454

merged 7 commits into from
Sep 12, 2018

Conversation

FlxB2
Copy link
Contributor

@FlxB2 FlxB2 commented Sep 12, 2018

% sign and other characters like $ are now converted to "percent" and "dollar"
see #441

Pull request status:

  • Tests added/updated
  • 80 % Coverage
  • Code conventions
  • Doku required and added
  • Ready for review

@FlxB2 FlxB2 requested a review from buddy200 September 12, 2018 11:32
Copy link

@sonarqubecloud sonarqubecloud bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SonarQube analysis found issues:
Bug Bugs: 1
Vulnerability Vulnerabilities: 0
Code Smell Code Smells: 2

Including the following issue(s) which could not be reported in line:

  1. Code Smell Code Smell: Add a new line at the end of this file. (more)

See all issues in SonarCloud

@buddy200 buddy200 merged commit a597315 into dev Sep 12, 2018
@buddy200 buddy200 deleted the characterConversion branch September 12, 2018 15:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants