Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implementing BLAKE3 opcode #112

Merged
merged 2 commits into from
Mar 19, 2024
Merged

implementing BLAKE3 opcode #112

merged 2 commits into from
Mar 19, 2024

Conversation

fengjian
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Mar 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 30.9%. Comparing base (7694aea) to head (bf50a8c).

Files Patch % Lines
src/isa/exec.rs 0.0% 8 Missing ⚠️
src/isa/bytecode.rs 0.0% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           master    #112     +/-   ##
========================================
- Coverage    31.0%   30.9%   -0.1%     
========================================
  Files          23      23             
  Lines        6489    6500     +11     
========================================
  Hits         2011    2011             
- Misses       4478    4489     +11     
Flag Coverage Δ
rust 30.9% <0.0%> (-0.1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fengjian
Copy link
Contributor Author

fengjian commented Mar 18, 2024

@dr-orlovsky
please review the code.

@fengjian
Copy link
Contributor Author

Rebase merge all commits

Copy link
Member

@dr-orlovsky dr-orlovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one small change, the rest LGTM

src/isa/instr.rs Outdated Show resolved Hide resolved
Co-authored-by: Dr. Maxim Orlovsky <[email protected]>
Copy link
Member

@dr-orlovsky dr-orlovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK bf50a8c

@dr-orlovsky dr-orlovsky merged commit 895e7ad into AluVM:master Mar 19, 2024
25 of 26 checks passed
@dr-orlovsky
Copy link
Member

Congrats and thank you for the first contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants