Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: tokenscript engine js #3346

Merged
merged 14 commits into from
Feb 20, 2024
Merged

Feat: tokenscript engine js #3346

merged 14 commits into from
Feb 20, 2024

Conversation

micwallace
Copy link
Contributor

Use embedded tokenscript viewer when TSML schema is greater than 2022-09

Copy link

Pull reviewers stats

Stats of the last 30 days for alpha-wallet-android:

User Total reviews Time to review Total comments

Copy link

codecov bot commented Jan 18, 2024

Codecov Report

Attention: 474 lines in your changes are missing coverage. Please review.

Comparison is base (b36cc41) 7.04% compared to head (8505508) 6.98%.

Files Patch % Lines
.../com/alphawallet/app/ui/TokenScriptJsActivity.java 0.00% 336 Missing ⚠️
...m/alphawallet/app/ui/AdvancedSettingsActivity.java 0.00% 73 Missing ⚠️
...com/alphawallet/app/ui/NFTAssetDetailActivity.java 0.00% 23 Missing ⚠️
.../com/alphawallet/app/widget/FunctionButtonBar.java 0.00% 20 Missing ⚠️
...va/com/alphawallet/app/ui/TransferNFTActivity.java 0.00% 6 Missing ⚠️
...let/app/repository/SharedPreferenceRepository.java 0.00% 3 Missing ⚠️
...allet/app/viewmodel/AdvancedSettingsViewModel.java 0.00% 3 Missing ⚠️
...c/main/java/com/alphawallet/app/web3/Web3View.java 0.00% 3 Missing ⚠️
...hawallet/app/viewmodel/TokenFunctionViewModel.java 0.00% 2 Missing ⚠️
.../com/alphawallet/app/widget/ActionSheetDialog.java 0.00% 2 Missing ⚠️
... and 3 more
Additional details and impacted files
@@             Coverage Diff             @@
##             master   #3346      +/-   ##
===========================================
- Coverage      7.04%   6.98%   -0.06%     
  Complexity      878     878              
===========================================
  Files           679     680       +1     
  Lines         46921   47315     +394     
  Branches       4755    4786      +31     
===========================================
  Hits           3304    3304              
- Misses        43325   43719     +394     
  Partials        292     292              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@micwallace micwallace marked this pull request as ready for review January 31, 2024 11:09
@JamesSmartCell JamesSmartCell force-pushed the feat/tokenscript-engine-js branch from 203011c to c18d4ec Compare February 19, 2024 07:51
@JamesSmartCell JamesSmartCell added this pull request to the merge queue Feb 20, 2024
Merged via the queue into master with commit f60184a Feb 20, 2024
9 checks passed
@JamesSmartCell JamesSmartCell deleted the feat/tokenscript-engine-js branch February 20, 2024 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants