Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Linea, Linea Test and Holesky #3328

Merged
merged 2 commits into from
Oct 15, 2023
Merged

Add Linea, Linea Test and Holesky #3328

merged 2 commits into from
Oct 15, 2023

Conversation

JamesSmartCell
Copy link
Member

No description provided.

@github-actions
Copy link

Pull reviewers stats

Stats of the last 30 days for alpha-wallet-android:

User Total reviews Time to review Total comments

@@ -0,0 +1,51 @@
<vector xmlns:android="http://schemas.android.com/apk/res/android"
android:width="153dp"
android:height="238dp"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error   🚫
📚 Limit vector icons sizes to 200×200 to keep icon drawing fast; see https://developer.android.com/studio/write/vector-asset-studio#when for more
🛠️ VectorRaster

by Android Lint 🤖

@@ -0,0 +1,51 @@
<vector xmlns:android="http://schemas.android.com/apk/res/android"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warning ⚠️  
📚 The resource R.drawable.ic_linea appears to be unused
🛠️ UnusedResources

by Android Lint 🤖

@codecov
Copy link

codecov bot commented Oct 15, 2023

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Files Coverage Δ
app/src/main/java/com/alphawallet/app/C.java 57.14% <ø> (ø)
...om/alphawallet/app/repository/TokenRepository.java 5.74% <0.00%> (-0.03%) ⬇️
...ava/com/alphawallet/app/service/AWHttpService.java 57.31% <0.00%> (-1.44%) ⬇️
...lphawallet/app/repository/EthereumNetworkBase.java 46.66% <85.00%> (+1.12%) ⬆️
...ava/com/alphawallet/app/service/TickerService.java 20.00% <33.33%> (+0.32%) ⬆️

📢 Thoughts on this report? Let us know!.

@@ -0,0 +1,51 @@
<vector xmlns:android="http://schemas.android.com/apk/res/android"
android:width="153dp"
android:height="238dp"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error   🚫
📚 Limit vector icons sizes to 200×200 to keep icon drawing fast; see https://developer.android.com/studio/write/vector-asset-studio#when for more
🛠️ VectorRaster

by Android Lint 🤖

@@ -0,0 +1,51 @@
<vector xmlns:android="http://schemas.android.com/apk/res/android"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warning ⚠️  
📚 The resource R.drawable.ic_linea appears to be unused
🛠️ UnusedResources

by Android Lint 🤖

@JamesSmartCell JamesSmartCell merged commit 3df03e2 into master Oct 15, 2023
7 checks passed
@JamesSmartCell JamesSmartCell deleted the add-new-chains branch October 15, 2023 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant