Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed apostrophe from JSON #3084

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

jayohTM
Copy link

@jayohTM jayohTM commented Feb 12, 2023

No description provided.

@jayohTM
Copy link
Author

jayohTM commented Feb 12, 2023

Apologies for 2 commits on this request, inadvertently used an apostrophe in the app json file.

@JamesSmartCell
Copy link
Member

Hi @jayohTM I am trying Stakepark, it looks good however I'm not sure what it's supposed to do.

I get to this screen:

Screenshot_20230222_193313_AlphaWallet

Bu then it goes blank after a few seconds, after it looks like it's loading something.

The WalletConnect interface didn't connect (but that could be down to WalletConnect; they have deprecated the v1 interface - you should switch to v2 - not sure if Web3Modal have upgraded their package yet).

@jayohTM
Copy link
Author

jayohTM commented Feb 22, 2023

Bu then it goes blank after a few seconds, after it looks like it's loading something.

Hey @JamesSmartCell, thanks for checking and the feedback. After the loading screen, you should either see active staking assets in your wallet or a 'no active stakes' screen as shown here:

Screenshot 2023-02-22 at 8 48 10 AM

We are still working our our WalletConnect issues. It is related to V2 and RainbowKit, our wallet interface. Shouldn't be too awful long, but the injected wallet interfaces works (as here with AlphaWallet).

Edit: I just realized we're in the Android repo. Will do some additional testing.

@jayohTM
Copy link
Author

jayohTM commented Feb 22, 2023

Had success testing on Android running under Windows 11 (Android Subsystem):

image

@JamesSmartCell
Copy link
Member

Thanks I'll try again. What kit are you planning to use for WC2? We need to upgrade our test harness app to use WC2.

@jayohTM
Copy link
Author

jayohTM commented Feb 23, 2023

We are planning keeping RainbowKit, since it's working well for everything besides WC2. Here is some discussion on the efforts: rainbow-me/rainbowkit#1003 (comment)

@jayohTM
Copy link
Author

jayohTM commented Apr 22, 2023

@JamesSmartCell We've launched a bunch of fixes on our end. It's still WalletConnect V1 for now, but V2 support should be a simple patch once our WalletConnect Cloud ID is approved.

Please let me know if you run into any new issues. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants