Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2850 remove api23 support #2887

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

2850 remove api23 support #2887

wants to merge 11 commits into from

Conversation

seabornlee
Copy link
Contributor

  • Remove version check code
  • Use original web3j lib
  • Use stream API anyMatch
  • Use Stream.mapToInt
  • Use stream API
  • Use stream API filter.count
  • Use stream API mapToInt
  • Use stream mapToInt
  • Refactor: elimate for loop duplication
  • Use stream noneMatch API
  • Use stream findFirst API

@seabornlee seabornlee force-pushed the 2850-remove-api23-support branch from be68fdb to 5fb051d Compare October 28, 2022 04:10
JamesSmartCell
JamesSmartCell approved these changes Oct 31, 2022
View reviewed changes
Copy link
Member

@JamesSmartCell JamesSmartCell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, will double check the test before merge.

@JamesSmartCell JamesSmartCell force-pushed the master branch 2 times, most recently from a1cfb4f to 8acd3f7 Compare December 7, 2022 02:09
@JamesSmartCell
Copy link
Member

@seabornlee can you check why the tests were failing (probably an incidental thing) and rebase this to latest master so we can finally merge it?

@seabornlee
Copy link
Contributor Author

@seabornlee can you check why the tests were failing (probably an incidental thing) and rebase this to latest master so we can finally merge it?

Ok.

@JamesSmartCell
Copy link
Member

@seabornlee could you rebase this PR so we can merge it?

@seabornlee
Copy link
Contributor Author

@seabornlee could you rebase this PR so we can merge it?

Ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JamesSmartCell JamesSmartCell JamesSmartCell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seabornlee @JamesSmartCell