Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix silent err #474

Merged
merged 2 commits into from
Nov 19, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
update error check
  • Loading branch information
Almenon committed Nov 19, 2024
commit 088e5e621a84910e6ce20b58421c7d89b0c92208
2 changes: 1 addition & 1 deletion src/PreviewManager.ts
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@ export default class PreviewManager {
private warnIfOutdatedPythonVersion(pythonPath: string){
PythonShell.getVersion(`"${pythonPath}"`).then((out)=>{
let version = out.stdout ? out.stdout : out.stderr
if(version?.includes("Python 3.4") || version?.includes("Python 2")){
if(version?.includes("Python 2") || version?.includes("Python 3.4") || version?.includes("Python 3.5") || version?.includes("Python 3.6")){
vscode.window.showErrorMessage(`AREPL no longer supports ${version}.
Please upgrade or set AREPL.pythonPath to a diffent python.
AREPL needs python 3.7 or greater`)
Expand Down