Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ARI and Hausdorff #33

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

Added ARI and Hausdorff #33

wants to merge 16 commits into from

Conversation

lukezhang-811
Copy link
Collaborator

No description provided.

@berl
Copy link
Collaborator

berl commented Dec 11, 2024

hi @lukezhang-811 and @egelfan2 thanks for this!

a few points:
the tests directory is a bit special: the test_spatial_compare.py file is ran automatically on pull requests to test functions in the spatial_compare.py file. so tests for new functions inside spatial_compare.py should be written as new functions inside test_spatial_compare.py.

So here's how we can move this forward:

  • move the new test functions into the test_spatial_compare.py following the format there. to make sure this works before pushing back here, run pytest in your spatial_compare directory and make sure everything passes.
  • delete the notebooks in tests. if there is stuff that you want users to see, move it to a new notebook in the notebooks directory
  • run black to fix formatting
  • commit results back to this branch
    when you commit back here with updated tests, you'll see the tests run through github actions and you should get all green checkmarks!

@egelfan2
Copy link
Collaborator

Sounds good, I'll take care of these steps ASAP!

@egelfan2
Copy link
Collaborator

Hey all, updated the issues listed above:

  • shifted previously added tests to their appropriate locations
  • added more tests
  • adjusted all file formatting with black
  • confirmed all tests succeed and checks pass

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants