-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Danielsf/dev/downsampled/video #415
Conversation
median filtering is the wrong move, apparently
b56f9d4
to
5427308
Compare
5d2157a
to
b9e2abb
Compare
Codecov Report
@@ Coverage Diff @@
## main #415 +/- ##
==========================================
- Coverage 92.47% 92.32% -0.15%
==========================================
Files 84 88 +4
Lines 5182 5423 +241
==========================================
+ Hits 4792 5007 +215
- Misses 390 416 +26
Flags with carried forward coverage won't be shown. Click here to find out more.
|
where "bad" is defined as "not an integer multiple of the number of frames being grouped together by downsampling"
add descriptions to DownsampleVideo sub class schemas
325c5fb
to
d787f19
Compare
required=False, | ||
default=8, | ||
allow_none=False, | ||
description=("Factor by which to speed up output movie")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add the same description here as in the code, which is better
Factor by which to speed up the movie *after downsampling* when writing
to video (in case you want a smaller file that can be played back
faster)
@@ -0,0 +1 @@ | |||
# empty |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this package should just be called video
, as it's possible to apply no downsampling but still create a video
import pathlib | ||
|
||
|
||
class SideBySideDownsamplerSchema(DownsampleBaseSchema): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SideBySideVideoSchema
The python 3.7 build keeps timing out on CircleCI on tests that this PR does not touch. CircleCI reports itself as in a degraded state. I'm going to merge now on the assumption that that is our problem. If the problem does not resolve itself tomorrow, we can look into it. |
This PR adds a utility to generate downsampled video files (.avi, .mp4, etc.) for those who do not want to use the .webm files currently output by the motion correction pipeline. There is a module (
single_video
) for generating a single downsampled video and a module (side_by_side_video
) for showing two videos side by side (e.g. pre- and post-motion correction). Examples of the side by side video module's output can be found here/allen/aibs/informatics/danielsf/downsampling_example
This work is not associated with any specific ticket (unless maybe #412), but having this tool will be necessary to enable the science team to evaluate our prospective motion correction configurations.