Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/gh-issues-and-forum-links #97

Merged
merged 3 commits into from
May 15, 2024

Conversation

BrianWhitneyAI
Copy link
Contributor

This PR adds in two links to the HELP_OPTIONS dropdown at the bottom of the app. The first is to our GH issues page and the other is to image.sc for futute forums. This PR aims to resolve #90

Copy link
Contributor

@aswallace aswallace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that for desktop it currently opens the links in a new Electron window; would we want it to open in a browser window instead?

iconProps: {
iconName: "Bug",
},
title: "Opens the FMS File Explorer GH issues page",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I lean towards spelling out GitHub for non SWEs but that's just a personal preference.
I'm also considering the wording of the menu text. Would "Report an Issue" or something similar be more universally familiar than submit?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated in b413566

@BrianWhitneyAI BrianWhitneyAI merged commit 679da45 into main May 15, 2024
3 checks passed
@SeanLeRoy SeanLeRoy deleted the feature/gh-issues-and-forum-links branch May 23, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add GH issues & forum link to app
3 participants