Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/create thumbnail view #77

Merged
merged 4 commits into from
Apr 18, 2024
Merged

Conversation

aswallace
Copy link
Contributor

@aswallace aswallace commented Apr 15, 2024

Description

This allows users to toggle between a list view and two different size thumbnail views in the explorer per #69.
The main new component is LazilyRenderedThumbnail, which follows the patterns set by LazilyRenderedRow.
The major logic changes are in FileList (the parent component) which contains the InfiniteLoader component. Note: InfiniteLoader is an external component that only supports lists by default, so needed to add in some customization to accommodate a grid.

Testing

Tested manually and with new unit tests.

  • Made sure the row/column to standard index conversion is consistent between view types and the right file stays selected between views
  • Different views still work when grouping via the annotation hierarchy
  • Using shift or ctrl to select still works as expected with all view types

To do:

There are a couple UX things that would be great to run by someone:

  • What do we want the toggle & its icons to look like? Currently they're in the top right near the font size toggle
  • Do we want custom icons for different file types (e.g., csv, tiff, czi ?) Right now they all use the same default "no image" icon

Screenshots

Large size thumbnails
Large thumbnails

Small size thumbnails
Small thumbnails

Using annotation hierarchy to group
Screenshot 2024-04-15 at 11 43 19 AM

@@ -114,7 +114,7 @@
}

.font-size-button {
background-color: darkgrey;
background-color: lightgrey;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made this change since I was having a hard time reading the buttons with the darker background

Copy link
Contributor

@SeanLeRoy SeanLeRoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fantastic!! Great job 🎉

packages/core/components/FileDetails/index.tsx Outdated Show resolved Hide resolved
@aswallace aswallace merged commit 784f172 into master Apr 18, 2024
3 checks passed
@aswallace aswallace deleted the feature/create-thumbnail-view branch April 18, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants