Feature/allow annotation interactions while loading #56
Conversation
| @@ -84,6 +85,9 @@ export default function DirectoryTree(props: FileListProps) { | |||
| aria-multiselectable="true" | |||
| id={Tutorial.FILE_LIST_ID} | |||
| > | |||
| {!error && (!content || (Array.isArray(content) && !content.length)) && ( | |||
There was a problem hiding this comment.
I think it might be useful to pretty print the filters applied in the empty file message. It would duplicate the UI components that display the filters themselves, but may be useful to those unfamiliar with the app. What do you think? We could get this information from the fileSet variable.
There was a problem hiding this comment.
That makes sense. So something like "No files found with {list of comma-separated human readable filters}" or "Filters applied: {ul of filters}"
There was a problem hiding this comment.
Yeah I think that would be perfect, probably including the hierarchy too
There was a problem hiding this comment.
Addressed in most recent commit
| import AnnotationFilter from "../AnnotationSidebar/AnnotationFilter"; | ||
|
|
||
| import styles from "./FilterMedallion.module.css"; | ||
|
|
||
| export interface Filter { |
There was a problem hiding this comment.
Moved this interface out into ../entity/FileFilter since it gets used a couple times
| The unit tests for each of the packages can also be run independently, using `npm run test:core`, `npm run test:desktop`, | ||
| or `npm run test:web`, respectively. | ||
|
|
||
| To run the linter, use `npm run lint`, and for typechecking, use `npm run typeCheck`. |
| text-decoration: none; | ||
| } | ||
|
|
||
| .filter:not(:last-child):after { |
| }).filter((filter) => filter.displayValue !== undefined); | ||
| return groupBy(filters, (filter) => filter.name); | ||
| } | ||
| ); |
There was a problem hiding this comment.
I like the createSelector solution! The only useMemo approach that I have thought of for this would be either to move the useMemo call up in the component hierarchy to a common ancestor of all the places you want to use it. This seems preferable.
aswallace
deleted the
feature/allow-annotation-interactions-while-loading
branch
Description
This allows users to continue to interact with annotations in the 'Available Annotations' list while they are loading.
disabledstyling for loading itemsFileListcomponent so that it can be re-used for theDirectoryTree:(so removed it from the unit test, can definitely add it back inTesting
Tested manually on local build, on site and off site (with VPN)
closes #51