-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
368: Use Local File Path annotation #370
base: feature/local_cloud_toggle
Are you sure you want to change the base?
368: Use Local File Path annotation #370
Conversation
@pgarrison If we are specifically calling out VAST in the "Copy files to local NAS (VAST)" modal @BrianWhitneyAI was working on, perhaps we should be consistent and mention VAST here? Without potentially understanding the whole picture, I usually think you should be more general in terminology so that if VAST changes to something else someday, we won't have to worry about updates. BUT, I read Kevin M's recent comment somewhere that he was happy to see us calling VAST out specifically, which makes me think users have been confused in the past about what our local storage was called? To be consistent, maybe the label should say (Local VAST) or (Local/VAST)? |
@lynwilhelm I realized I uploaded the wrong screenshot -- it's fixed now. The current version of this PR says "File Path (Vast)". Does that seem good to you, or do you think "File Path (Local Vast)" is more clear? @pgarrison Classic;) IDK, I slightly lean toward calling it local storage too. Whatever you think...but last thing is VAST is an acronym so I think you should do uppercase, right? |
packages/core/services/AnnotationService/HttpAnnotationService/index.ts
Outdated
Show resolved
Hide resolved
Lyndsay left the following comment.
So I think this PR needs to be updated to "File Path (Local VAST)" before merging. |
Purpose
Render the new "Local File Path" annotation nicely. The goal is to display something like this:
File Path (Vast) /mypath/aics/software/apps/staging/fss/data/7fb/6fb/b0f/6bd/7d5/1db/a4c/1e4/2a6/2a5/c7/aicsfiles-test-a4cb9af6-bcfa-11ef-8fe8-0242ac110002.czi
Closes #368
Closes #369
Changes
HttpAnnotationService
, which has a few benefits.FileAnnotationList
).Testing
HttpAnnotationService
Notes
File Path (Local)
was used beforeFile Path (Vast)
. I don't have a strong preference: please weigh in. The newFMSAnnotationPresentationLayer
makes it easy to change it up.FMSAnnotationPresentationLayer
nor the choice to put this annotation-renaming logic here instead of FES or changing the name in LabKey and the ETL pipeline.