Remove react dev tools for electron #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgarrison
requested review from
SeanLeRoy,
kmitcham,
aswallace and
BrianWhitneyAI
aswallace
approved these changes
Dec 17, 2024
kmitcham
approved these changes
Dec 17, 2024
|
Haven't had time to debug the build failure in the github action. I am able to build locally. Let me know if you have any clues. |
SeanLeRoy
approved these changes
Dec 18, 2024
|
Thanks @aswallace for helping with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
I couldn't run the development version of BFF desktop on my machine (#364).
Closes #364
Changes
Remove React Dev Tools entirely from the electron development build.
Testing
npm run testnpm --prefix packages/desktop run startopens a BFF window on my machine.