Feature/bff #358
Merged
Feature/bff #358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imashmash
had a problem deploying
to
production
GitHub Actions
Failure
|
Branch "feature/bff" is not allowed to deploy to production due to environment protection rules. - that's why it failed |
anl
requested review from
pgarrison,
aswallace,
SeanLeRoy,
yrkim98 and
BrianWhitneyAI
anl
reviewed
Dec 11, 2024
gmoynihan88
approved these changes
Dec 11, 2024
anl
approved these changes
Dec 12, 2024
There was a problem hiding this comment.
@pgarrison @aswallace @BrianWhitneyAI @yrkim98 @tyler-foster Could one of you review this PR also?
SeanLeRoy
reviewed
Dec 12, 2024
BrianWhitneyAI
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds BFF domain S3 bucket and CloudFront distribution ID
Test:
https://github.com/AllenInstitute/biofile-finder/actions/runs/12282978093