Feature/add better column control #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeanLeRoy
requested review from
BrianWhitneyAI,
aswallace,
kmitcham and
pgarrison
…nstitute/aics-fms-file-explorer-app into feature/add-better-column-control
kmitcham
reviewed
Nov 20, 2024
| @@ -22,7 +22,7 @@ export default function EmptyFileListMessage() { | |||
| > | |||
| GitHub | |||
| </a> | |||
| if you still expect there to be matches present. | |||
| if you expect there should be matches present for query. | |||
There was a problem hiding this comment.
oof will there ever be a day I don't have a typo
kmitcham
approved these changes
Nov 20, 2024
BrianWhitneyAI
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Users have wanted to control which columns are shown in shared queries for a while. This adds them to the query arguments decoded/encoded.
While I was in here I noticed the columns & file view were tracked in multiple pieces. I added an interface and enum (respectively) to capture those pieces of information more simply.
Testing
Tested against AICS FMS, cloud hosted, and local data sources
Related Issue
Resolves #329