-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature/move-files-styling #320
feature/move-files-styling #320
Conversation
Could definitely use some help with the wording here. Spacing is also not great. |
I suggest not using "Cache" or "lease": I think these terms will be unfamiliar in this context. Perhaps the following instead: Copy Files to Local NAS (Vast) Files copied to the local NAS (Vast) are stored with a 180-day expiration, after which they revert to cloud-only. To extend the expiration, simply reselect the files and confirm the update. Files that are already on Vast: Extend expiration Files to download to Vast |
resolved in a94c95e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM assuming we add the total file size count to the bottom of both tables as discussed in slack
Thanks for requesting my eyes @pgarrison. Your suggestions were right on and Brian and I chatted on a couple additional minor edits that should now be resolved. |
Nit: the expiration/eviction period is currently 182 days, not 180. We can change this on the backend if desired. Could also say '6 months' on the frontend, or maybe it's not an important distinction to the users 🤷 . Just wanted to let you know if you were unaware Also, glad to see all of my integration test files are being used for something else 😆 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Glad to see us using the word 'vast' instead of cache in much of the UI, as I think that is more clear to our users.
Those tests have been so helpful! The original text said ~180 days, knowing it was 182. I think its ok to tell users 180 here, Im also ok with 6 months |
Yeah I'm still unsure about "NAS" and if users will know what that is but Vast is now alot clearer. |
I think leaving out "local NAS" entirely makes sense. I don't think our users really know what it means either. |
The purpose of this PR is to resolve #315 and clean up the "Copy files" modal. This PR only resolves some of the items as UX changes related to to some of the requests are dependent on future ETL work.