feature/toggle-modal #311

BrianWhitneyAI · 2024-10-25T20:09:12Z

Description

We want to present to users the option to move files on and off NAS Cache. In order to do this and convey the significance of the action we want to add the following functionality:

Add Move menu item to dropdown with options “Off NAS Cache” & “Onto NAS Cache”
Modal component to report effect of move ( total # of file and total size )

Relevant Issues

Resolved Add "Move" menu item to batch file selection. #290 as part of Feature Request: Local / Cloud upload/delete toggle. #289

BrianWhitneyAI · 2024-10-25T20:15:59Z

Move option on file selection.

BrianWhitneyAI · 2024-10-25T20:16:21Z

Move Modal.

BrianWhitneyAI · 2024-10-25T20:18:28Z

What still needs to be done.

We need some semblance of what files are already in local or in cloud so we can convey more accurately how many files and the total file size is moving.
We need the actual dispatch. right now confirming jus logs a message :)

saeliddp · 2024-10-25T23:33:55Z

General comment:

After a few rounds of discussion, we decided that we should not give BFF users the ability to move files off of the cache. Instead, once a file is moved onto the cache, it is given an expiration date (e.g. 6 months out). If a user later sends the request to cache the file again (while it's still in the cache), it will act as a 'refresh' on the expiration date.

Quick summary of why we made this decision:

Suppose user A decides to remove example.tif from the cache. How would user A know if another user is still using example.tif and still wants it on the cache? -> leads to unnecessary, costly (time and S3 $) 'cache battles'
We would need to prevent concurrency issues with 'remove from cache' and 'move to cache' actions
We do not expect space on the cache to be an issue once we make the transition to using cloud as primary storage, so there's not a lot of risk involved with setting a pretty distant expiration date
In the future (and if users want it), we could have expiration_date as an argument to the cache endpoint, giving users the option to say how long they need the file in local cache

What does this mean for BFF? (and this PR)

No need for Off NAS cache option
Eventually, probably want to surface expiration date if the file is already in the cache, give users the option to refresh that expiration date

packages/core/components/Modal/MoveFileManifest/index.tsx

SeanLeRoy · 2024-10-28T16:48:37Z

packages/core/components/Modal/MoveFileManifest/index.tsx

+ * Modal overlay for displaying details of selected files for NAS cache operations.
+ */
+export default function MoveFileManifest({ onDismiss }: ModalProps) {
+    // const dispatch = useDispatch(); //TODO: add onMove functionality


I think this PR should/can include the action that will eventually contain the call to FSS. What I mean is that you can dispatch a "moveFIles" action that you can create in the interaction state branch & create an empty "logics" in the logic middleware file that will just log to the console rather than call FSS for now

resolved in e159438 and 8c810a6

SeanLeRoy · 2024-10-28T16:53:02Z

packages/core/components/Modal/MoveFileManifest/index.tsx

+/**
+ * Formats a file size to a human-readable string.
+ */
+const formatFileSize = (size: number) => {


This should go after the imports, but I think we have a function for doing this sort of thing already. Look in the aggregate file box, that display already renders the appropriate byte unit.

resolved in ae06c75

SeanLeRoy · 2024-10-28T16:55:45Z

packages/core/components/Modal/MoveFileManifest/index.tsx

+            <div className={styles.fileListContainer}>
+                <ul className={styles.fileList}>
+                    {fileDetails.map((file) => (
+                        <li key={file.id} className={styles.fileItem}>


resolved in 77a52bd

SeanLeRoy · 2024-10-28T16:57:06Z

packages/core/hooks/useFileAccessContextMenu.ts

@@ -157,22 +157,26 @@ export default (filters?: FileFilter[], onDismiss?: () => void) => {
                    },
                    subMenuProps: {
                        items: [
+                            {


The "move" option that contains these should only be rendered when the data source is "AICS FMS" (there is a constant for that value)

resolved in f52d31c

SeanLeRoy · 2024-10-28T16:58:45Z

packages/core/state/interaction/reducer.ts

+        }),
+        [HIDE_VISIBLE_MODAL]: (state) => ({
+            ...state,
+            visibleModal: undefined,


Confused about this. Was the visible modal otherwise never being set to undefined? Did you create this action in another PR?

Whoops accidentally duplicated our existing. Resolved in 1e3c38b

packages/core/components/Modal/MoveFileManifest/MoveFileManifest.module.css

BrianWhitneyAI · 2024-10-28T20:49:49Z

New Screenshots

BrianWhitneyAI · 2024-10-28T21:20:44Z

New menu with only ONTO NAS

packages/core/components/Modal/MoveFileManifest/index.tsx

packages/core/hooks/useFileAccessContextMenu.ts

saeliddp

Thanks for working on this! Left a few comments related to users only being allowed to move files onto the cache

packages/core/state/interaction/actions.ts

BrianWhitneyAI · 2024-10-29T19:09:37Z

Heres what the menu looks like now

packages/core/components/Modal/MoveFileManifest/index.tsx

SeanLeRoy · 2024-10-30T17:24:27Z

packages/core/hooks/useFileAccessContextMenu.ts

-                        ],
-                    },
-                },
+                ...(isQueryingAicsFms


Lets move this option above "Download"

resolved in 034549d

SeanLeRoy · 2024-10-30T17:25:29Z

packages/core/components/Modal/MoveFileManifest/index.tsx

+        selection.selectors.getFileSelection,
+        FileSelection.selectionsAreEqual
+    );
+    const moveFileTarget = useSelector(interaction.selectors.getMoveFileTarget);


Now that we don't have a notion of moving on/off the cache it seems we can remove the idea of having a target. IMO this is likely a YAGNI since other than FMS we won't have control over moving files.

resolved in 034549d

SeanLeRoy · 2024-10-30T17:28:09Z

The list of files should have a gradient at the bottom of it to visually signal to users that there are more options

BrianWhitneyAI · 2024-10-31T23:59:47Z

The list of files should have a gradient at the bottom of it to visually signal to users that there are more options

resolved in a450c41

feature/toggle-modal

f2a0559

BrianWhitneyAI marked this pull request as ready for review October 25, 2024 20:20

BrianWhitneyAI requested review from SeanLeRoy and aswallace and removed request for SeanLeRoy October 25, 2024 20:20

BrianWhitneyAI self-assigned this Oct 25, 2024

BrianWhitneyAI requested a review from hughes036 October 25, 2024 20:33

SeanLeRoy requested changes Oct 28, 2024

View reviewed changes

BrianWhitneyAI added 7 commits October 28, 2024 11:11

add conditional show move menu item

f52d31c

modal list to table

77a52bd

reorder imports

1201a84

use existing filesize method

ae06c75

add placeholder action

e159438

add placeholder logic

8c810a6

remove duplicate reducer

1e3c38b

aswallace reviewed Oct 28, 2024

View reviewed changes

packages/core/components/Modal/MoveFileManifest/MoveFileManifest.module.css Show resolved Hide resolved

aswallace reviewed Oct 28, 2024

View reviewed changes

packages/core/components/Modal/MoveFileManifest/MoveFileManifest.module.css Outdated Show resolved Hide resolved

aswallace reviewed Oct 28, 2024

View reviewed changes

packages/core/components/Modal/MoveFileManifest/MoveFileManifest.module.css Outdated Show resolved Hide resolved

update styling for move modal

588447d

BrianWhitneyAI requested review from SeanLeRoy and aswallace October 28, 2024 20:50

remove off nas

741d415

aswallace requested a review from saeliddp October 28, 2024 22:11

saeliddp reviewed Oct 28, 2024

View reviewed changes

packages/core/components/Modal/MoveFileManifest/index.tsx Outdated Show resolved Hide resolved

saeliddp reviewed Oct 28, 2024

View reviewed changes

packages/core/hooks/useFileAccessContextMenu.ts Outdated Show resolved Hide resolved

saeliddp reviewed Oct 28, 2024

View reviewed changes

packages/core/hooks/useFileAccessContextMenu.ts Outdated Show resolved Hide resolved

saeliddp reviewed Oct 28, 2024

View reviewed changes

hughes036 reviewed Oct 29, 2024

View reviewed changes

packages/core/state/interaction/actions.ts Outdated Show resolved Hide resolved

update move only structure

1bc859f

BrianWhitneyAI requested review from saeliddp and hughes036 October 29, 2024 19:10

hughes036 approved these changes Oct 29, 2024

View reviewed changes

aswallace approved these changes Oct 29, 2024

View reviewed changes

packages/core/components/Modal/MoveFileManifest/index.tsx Outdated Show resolved Hide resolved

saeliddp approved these changes Oct 29, 2024

View reviewed changes

SeanLeRoy reviewed Oct 30, 2024

View reviewed changes

BrianWhitneyAI force-pushed the feature/toggle-modal branch from cdc82e5 to 1bc859f Compare October 31, 2024 22:54

BrianWhitneyAI added 2 commits October 31, 2024 15:56

remove loc target

034549d

add gradient

a450c41

BrianWhitneyAI requested a review from SeanLeRoy October 31, 2024 23:59

SeanLeRoy approved these changes Nov 4, 2024

View reviewed changes

BrianWhitneyAI merged commit dbb368e into feature/local_cloud_toggle Nov 4, 2024
3 checks passed

BrianWhitneyAI deleted the feature/toggle-modal branch November 4, 2024 22:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feature/toggle-modal #311

feature/toggle-modal #311

BrianWhitneyAI commented Oct 25, 2024 •

edited

Loading

BrianWhitneyAI commented Oct 25, 2024

BrianWhitneyAI commented Oct 25, 2024 •

edited

Loading

BrianWhitneyAI commented Oct 25, 2024

saeliddp commented Oct 25, 2024

SeanLeRoy Oct 28, 2024

BrianWhitneyAI Oct 28, 2024

SeanLeRoy Oct 28, 2024

BrianWhitneyAI Oct 28, 2024

SeanLeRoy Oct 28, 2024

BrianWhitneyAI Oct 28, 2024

SeanLeRoy Oct 28, 2024

BrianWhitneyAI Oct 28, 2024

SeanLeRoy Oct 28, 2024

BrianWhitneyAI Oct 28, 2024

BrianWhitneyAI commented Oct 28, 2024

BrianWhitneyAI commented Oct 28, 2024

saeliddp left a comment

BrianWhitneyAI commented Oct 29, 2024

SeanLeRoy Oct 30, 2024

BrianWhitneyAI Oct 31, 2024

SeanLeRoy Oct 30, 2024

BrianWhitneyAI Oct 31, 2024

SeanLeRoy commented Oct 30, 2024

BrianWhitneyAI commented Oct 31, 2024

feature/toggle-modal #311

feature/toggle-modal #311

Conversation

BrianWhitneyAI commented Oct 25, 2024 • edited Loading

Description

Relevant Issues

BrianWhitneyAI commented Oct 25, 2024

BrianWhitneyAI commented Oct 25, 2024 • edited Loading

BrianWhitneyAI commented Oct 25, 2024

saeliddp commented Oct 25, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

BrianWhitneyAI commented Oct 28, 2024

BrianWhitneyAI commented Oct 28, 2024

saeliddp left a comment

Choose a reason for hiding this comment

BrianWhitneyAI commented Oct 29, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SeanLeRoy commented Oct 30, 2024

BrianWhitneyAI commented Oct 31, 2024

BrianWhitneyAI commented Oct 25, 2024 •

edited

Loading

BrianWhitneyAI commented Oct 25, 2024 •

edited

Loading