Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LOAD button on dataset page bug #306

Merged
merged 3 commits into from
Oct 30, 2024
Merged

Conversation

SeanLeRoy
Copy link
Contributor

The "LOAD" button on the open-source datasets page doesn't actually load the dataset. This is because the pointer-events property here is preventing that. Resolves #300

Copy link
Contributor

@aswallace aswallace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only minor tradeoff from this is that the links in the "related publication" column won't be clickable in the dataset row. If we keep it that way, Lyndsay suggested that we should remove the blue link styling from that column so it doesn't look like it should be clickable (which we agreed should be fine since the link is still clickable from the side panel)

@SeanLeRoy
Copy link
Contributor Author

The only minor tradeoff from this is that the links in the "related publication" column won't be clickable in the dataset row. If we keep it that way, Lyndsay suggested that we should remove the blue link styling from that column so it doesn't look like it should be clickable (which we agreed should be fine since the link is still clickable from the side panel)

I think it still is? I'm confused about this, can you send me a video or screen share tomorrow?

@aswallace
Copy link
Contributor

Staging/prod: link has hoverable state and opens pub in new tab

Screen.Recording.2024-10-24.at.2.59.34.PM.mov

without pointer events: link is blue but clicking just opens the panel

Screen.Recording.2024-10-24.at.2.57.36.PM.mov

@kmitcham kmitcham removed their request for review October 28, 2024 16:17
@SeanLeRoy
Copy link
Contributor Author

The only minor tradeoff from this is that the links in the "related publication" column won't be clickable in the dataset row. If we keep it that way, Lyndsay suggested that we should remove the blue link styling from that column so it doesn't look like it should be clickable (which we agreed should be fine since the link is still clickable from the side panel)

Fixed in e66d5d7

@SeanLeRoy SeanLeRoy merged commit 6a8eaa9 into main Oct 30, 2024
1 check passed
@SeanLeRoy SeanLeRoy deleted the bugfix/load-button-does-not-load branch October 30, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Load button on datasets not loading
3 participants