-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LOAD button on dataset page bug #306
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only minor tradeoff from this is that the links in the "related publication" column won't be clickable in the dataset row. If we keep it that way, Lyndsay suggested that we should remove the blue link styling from that column so it doesn't look like it should be clickable (which we agreed should be fine since the link is still clickable from the side panel)
I think it still is? I'm confused about this, can you send me a video or screen share tomorrow? |
Staging/prod: link has hoverable state and opens pub in new tab Screen.Recording.2024-10-24.at.2.59.34.PM.movwithout pointer events: link is blue but clicking just opens the panel Screen.Recording.2024-10-24.at.2.57.36.PM.mov |
Fixed in e66d5d7 |
The "LOAD" button on the open-source datasets page doesn't actually load the dataset. This is because the pointer-events property here is preventing that. Resolves #300