Fix resize handle #151
Merged
Fix resize handle #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeanLeRoy
requested review from
kmitcham,
pgarrison,
aswallace and
BrianWhitneyAI
SeanLeRoy
changed the base branch from
main
to
feature/add-toggle-for-list-picker
SeanLeRoy
commented
Jun 28, 2024
| @@ -99,57 +99,55 @@ export default function FileDetails(props: Props) { | |||
| className={classNames(styles.root, styles.expandableTransition, props.className)} | |||
| id={FILE_DETAILS_PANE_ID} | |||
| > | |||
| <div className={styles.fileDetailsContent}> | |||
There was a problem hiding this comment.
Only change here is I deleted the <div className={styles.fileDetailsContent}> element which changed the indentation
aswallace
approved these changes
Jul 1, 2024
aswallace
reviewed
Jul 1, 2024
| className={styles.resizeHandle} | ||
| onMouseDown={(e) => resizeHandleOnMouseDown(e)} | ||
| // TODO:??? | ||
| onDoubleClick={resizeHandleDoubleClick} |
There was a problem hiding this comment.
unrelated to PR, I'm curious what this to do is/what the behavior will be
There was a problem hiding this comment.
Ah I can remove that TODO this actually just resets the width of the pane back to 20% from whatever it was
BrianWhitneyAI
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The resize handle was broken because the width of the rest of the app was set to a fixed
80%which meant that it wasn't considering the adjustment from the variable--file-details-widthwhich is what determines the right sidebar pane's width. After changing the width calcuation this worked, added some styling changes to make it not have strange horizontal scroll behavior.Resolves #141