Finish aligning app to design mockups #148
Conversation
SeanLeRoy
requested review from
kmitcham,
pgarrison,
aswallace and
BrianWhitneyAI
SeanLeRoy
changed the title
| margin: calc(var(--margin) / 2) calc(var(--margin) / 4); | ||
| padding: 3px 6px 6px 6px; | ||
| margin: 6px 0; | ||
| padding: 3px 6px 10px 6px; |
There was a problem hiding this comment.
Ok this is extremely minor and does not actually need to be changed but it does bother my brain a little bit that this isn't vertically centered on hover when empty
There was a problem hiding this comment.
I too wasn't sure about this, but it is in the spec so I went with it - I'll check in with Lyndsay and see
| @@ -27,16 +30,16 @@ | |||
|
|
|||
There was a problem hiding this comment.
Seeing a background box around the up down arrows. Is this intentional?
There was a problem hiding this comment.
ummmm idk why there are even up and down arrows for you... what browser is this?
There was a problem hiding this comment.
weird hopefully just a Windows thing... I'm going to try to remove with an overflow attribute but I'll add an issue to do some extensive browser and os testing
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
| @@ -8,19 +8,24 @@ | |||
| background-color: var(--highlight-background-color); | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Does this cover "Collapsed query state styling should be improved" addressed? It seems very similar to me.
There was a problem hiding this comment.
Yep - see the figma design here.
Description
This changeset is intended to finish aligning the application with the style guide Lyndsay laid out for us including a few adjustments. Here is what was done:
Testing
Tested locally on web and desktop
Related Issue
Resolves #139
Preview
Check it out on my workstation here