Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/complete dataset page styling #122

Merged
merged 7 commits into from
Jun 26, 2024

Conversation

aswallace
Copy link
Contributor

@aswallace aswallace commented Jun 18, 2024

Description

This is a follow-up to #101 , finishing some secondary UX tasks for the datasets page. Closes #119

  • Added sorting to dataset manifest table columns & styling to indicate clickable headers
  • Added links + styling to reference publication and DOI
  • Refactored dataset annotations into their own class, both to standardize them & also to get rid of DatasetColumns.ts (which had gross constants & duplicate code)
  • Included a partial fix to the router issue where back button has to be clicked multiple times to go back from app to datasets page, but only works after the first time re-routing. This seems to be somewhat built in to the way react-router pushes history

Not addressed

I have not found a feasible way to make a responsive horizontal overlay on the rows where the hover-state buttons will stick to the right side of the panel when the screen is small (instead of having to scroll right to find them) because of the way the table sets up inheritance. However, this is less urgent, since the same functionality is available when users click on the row to open the side panel

Testing

  • Tested on a mock manifest with more datasets since we don't have enough datasets to sort on yet
  • Added a couple unit tests

Screenshots

The gray overlay on CREATION DATE is a hover state
image

@aswallace aswallace linked an issue Jun 18, 2024 that may be closed by this pull request
@aswallace aswallace self-assigned this Jun 18, 2024
@aswallace aswallace merged commit 75016e1 into main Jun 26, 2024
3 checks passed
@aswallace aswallace deleted the feature/complete-dataset-page-styling branch June 26, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add incomplete functionality/styling to datasets page
3 participants