Add analytics to webapp #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
aswallace
requested review from
SeanLeRoy,
kmitcham,
pgarrison and
BrianWhitneyAI
kmitcham
approved these changes
Jun 13, 2024
BrianWhitneyAI
approved these changes
Jun 13, 2024
| @@ -4,9 +4,23 @@ | |||
| <meta charset="UTF-8"> | |||
| <meta name="viewport" content="width=device-width, initial-scale=1.0"> | |||
| <link rel="icon" type="image/png" href="logo.png" /> | |||
There was a problem hiding this comment.
Nit but I don't think you need the closing / for link
There was a problem hiding this comment.
I'm seeing some mixed info about whether that's still the case for html5 (vs html4)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds Google Tag Manager to the webapp to collect basic data about user traffic/interaction.
closes #116
Testing
Checked that gtm is showing up with a 200 in the Network tab for all the current routes.
Once these changes are deployed, we'll need to reach out to Thao to verify its presence
Notes
Edit: It sounds like most things will be configured through the Google Tag Manager interface itself, and then we can chat with the analytics team if we need something more advanced than what it currently will do