-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a gh action for aws deployment #111
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like there's some copy-paste issues and some indentation fixes needed. @SeanLeRoy should weigh in on how the actual build is done, those steps will likely need to be adjusted to match.
.github/workflows/aws-deployment.yml
Outdated
- name: Checkout | ||
uses: actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744 | ||
|
||
- uses: actions/setup-node@60edb5dd545a775178f52524783378180af0d1f8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SeanLeRoy These build steps will presumably need adjusting for your workflow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yeah this seems a bit different, I'll likely need to workshop this a bit. Does it just need to produce some build artifact at ./dist
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes - the deploy step picks them up from there (we could also change paths, if need be).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How should I go about testing this - if there is nothing in the ./dist
will the build fail (as in, could I safely run this workflow to see if I am placing the files in the correct way and place)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Andy Leonard <[email protected]>
Co-authored-by: Andy Leonard <[email protected]>
Modify build in AWS workflow
Description
This enables GitHub actions to publish to AWS, production and staging
How to review
...
Testing
...