Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the explorer (BioFile Finder) deployable to the web #106

Merged
merged 26 commits into from
May 21, 2024

Conversation

SeanLeRoy
Copy link
Contributor

@SeanLeRoy SeanLeRoy commented May 17, 2024

Description
This changeset adds the necessary platform specific services to enable the web version of the explorer (biofile finder). A large part of this is just moving things that were specific to a desktop format or were incompatible with how we could do things in the web into a format or workflow that works with both platforms.

Some things were added that could/should have been added before this PR in retrospec like having the selected query mirror the query args and a couple style changes like making it so you can select any metadata tag as a column rather than just those that are "available".

How to Review
I recommend spending time checking out the web/src/services and the various logics.tsx.

Testing
I tested this manually using AICS FMS on desktop and on the web (localhost) and added various unit tests

@SeanLeRoy SeanLeRoy changed the title Feature/enable web Make the explorer (BioFile Finder) deployable to the web May 17, 2024
@SeanLeRoy SeanLeRoy marked this pull request as ready for review May 20, 2024 16:16
@SeanLeRoy SeanLeRoy self-assigned this May 20, 2024
@SeanLeRoy SeanLeRoy requested a review from BrianWhitneyAI May 20, 2024 16:16
@SeanLeRoy SeanLeRoy assigned aswallace and unassigned aswallace May 20, 2024
@SeanLeRoy SeanLeRoy requested a review from aswallace May 20, 2024 16:17
@aswallace
Copy link
Contributor

Currently having trouble running the desktop version of the app on this branch but it may just be my local set up, would be great if someone else could also verify.

Seeing this error on render: Uncaught TypeError: Cannot read properties of undefined (reading 'sortColumn')

@SeanLeRoy
Copy link
Contributor Author

Currently having trouble running the desktop version of the app on this branch but it may just be my local set up, would be great if someone else could also verify.

No such error for me ☹️

@BrianWhitneyAI
Copy link
Contributor

Currently having trouble running the desktop version of the app on this branch but it may just be my local set up, would be great if someone else could also verify.

No such error for me ☹️

Likewise did not see an error

Copy link
Contributor

@aswallace aswallace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally

  • downloading to parquet, json, csv
  • downloading individual files
  • opening files in 3d web viewer and labkey
  • query arg persistence

@aswallace
Copy link
Contributor

aswallace commented May 20, 2024

Currently having trouble running the desktop version of the app on this branch but it may just be my local set up, would be great if someone else could also verify.

Appears to be a PersistedConfig issue again for me -- On initial load, my persisted query did not have a parts attribute so it read as undefined. Was able to get around it in a hacky way but may not be a permanent solution

text: "Other...",
title: "Select an application to open the selection with",
onClick() {
dispatch(interaction.actions.promptForNewExecutable(filters));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing this locally, does not seem to open the selected app for me

@SeanLeRoy SeanLeRoy mentioned this pull request May 21, 2024
@SeanLeRoy
Copy link
Contributor Author

Currently having trouble running the desktop version of the app on this branch but it may just be my local set up, would be great if someone else could also verify.

Appears to be a PersistedConfig issue again for me -- On initial load, my persisted query did not have a parts attribute so it read as undefined. Was able to get around it in a hacky way but may not be a permanent solution

I wonder if this is because you have tried a previous iteration of this branch then. The schema for the persisted config changes for the "queries" key during the development of this branch. Normally when changing the schema I'd write a migration in, but since it was a branch in development it didn't seem it would matter alas

@SeanLeRoy SeanLeRoy merged commit 08c8311 into main May 21, 2024
3 checks passed
@SeanLeRoy SeanLeRoy deleted the feature/enable-web branch May 23, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants