-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the explorer (BioFile Finder) deployable to the web #106
Conversation
Currently having trouble running the desktop version of the app on this branch but it may just be my local set up, would be great if someone else could also verify. Seeing this error on render: |
No such error for me |
Likewise did not see an error |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally
- downloading to parquet, json, csv
- downloading individual files
- opening files in 3d web viewer and labkey
- query arg persistence
Appears to be a PersistedConfig issue again for me -- On initial load, my persisted query did not have a |
text: "Other...", | ||
title: "Select an application to open the selection with", | ||
onClick() { | ||
dispatch(interaction.actions.promptForNewExecutable(filters)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing this locally, does not seem to open the selected app for me
I wonder if this is because you have tried a previous iteration of this branch then. The schema for the persisted config changes for the "queries" key during the development of this branch. Normally when changing the schema I'd write a migration in, but since it was a branch in development it didn't seem it would matter alas |
Description
This changeset adds the necessary platform specific services to enable the web version of the explorer (biofile finder). A large part of this is just moving things that were specific to a desktop format or were incompatible with how we could do things in the web into a format or workflow that works with both platforms.
Some things were added that could/should have been added before this PR in retrospec like having the selected query mirror the query args and a couple style changes like making it so you can select any metadata tag as a column rather than just those that are "available".
How to Review
I recommend spending time checking out the
web/src/services
and the variouslogics.tsx
.Testing
I tested this manually using AICS FMS on desktop and on the web (localhost) and added various unit tests