Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/Make fuzzy search optional #102

Closed
wants to merge 3 commits into from

Conversation

aswallace
Copy link
Contributor

Description

This is a draft of the UI side of the work to have search be exact by default with the option to toggle fuzzy search in the search modal. This should not be merged until the FES changes are deployed, I'm just opening the PR to a stable state so it can be picked up again

Changes

  • Added the fuzzy search parameter to state and as a FileExplorerURL parameter
  • Currently have a placeholder checkbox to allow users to toggle fuzzy search

Here's what the shareable link would look like now:
fms-file-explorer://{"groupBy":[],"filters":[{"name":"uploaded","value":"RANGE(2023-05-13T07:00:00.000Z,2024-05-14T06:59:59.501Z)"},{"name":"file_name","value":"test"}],"fuzzyFilters":[{"annotationName":"file_name"}],"openFolders":[],"sort":{"annotationName":"uploaded","order":"DESC"}}

Which would generate the following url query: from=0&limit=56&file_name=test&uploaded=RANGE(2023-05-13T07:00:00.000Z,2024-05-14T06:59:59.501Z)&sort=uploaded(DESC)&fuzzy=file_name

Testing

Tested manually with an EC2 instance of FES (the local version has the fuzzy search changes, but hasn't been deployed) and staging version of Mongo.
Updated unit tests

Screenshot

image

@aswallace aswallace marked this pull request as draft May 21, 2024 21:16
@aswallace
Copy link
Contributor Author

aswallace commented Jul 2, 2024

Branch is deprecated, closing in favor of #154

@aswallace aswallace closed this Jul 2, 2024
@aswallace aswallace deleted the feature/make-fuzzy-search-optional branch July 2, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant