Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSPE-391: Adding Demand Execution Constructs to CDK Lib #9

Merged
merged 6 commits into from
Jun 5, 2024

Conversation

rpmcginty
Copy link
Collaborator

@rpmcginty rpmcginty commented Jun 4, 2024

  • misc updates
  • minor updates to constructs_.assets
  • misc changes, import cleanup
  • updating sfn fragments (data sync, demand)
  • top-level stack changes to core app (example)

What's in this Change?

  • adding fragments for demand execution step function
  • providing example stacks for how to set it up
  • fixing imports in various places

Testing

image

from aibs_informatics_cdk_lib.constructs_.s3 import EnvBaseBucket, LifecycleRuleGenerator


class Storage(EnvBaseConstruct):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would we be able to use this construct even for external buckets? Or is this only intended to be used in situations where we are creating (and fully controlling) the s3 bucket(s)?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a simple construct and not something we would use in merscope specifically. but I would define the storage aibs s3 bucket and use similar to the buckets specified here.

Comment on lines +137 to +138
env_base.get_construct_id(id),
state_machine_name=env_base.get_state_machine_name(name) if name else None,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Under what circumstances would we want to allow state_machine_name to be None? Aren't the autogenerated names really hard to track (when we need to track down where the state machine is defined)?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, but sometimes we don't care exactly what it is. I am thinking about cases where the state machine will be a nested state machine from which we can find in the top-level named state machine.

@rpmcginty rpmcginty requested a review from njmei June 5, 2024 02:33
Copy link
Collaborator

@njmei njmei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minv_cpus (min_vcpus) still doesn't look to have been fixed in BatchEnvironmentConfig class?

@rpmcginty
Copy link
Collaborator Author

minv_cpus (min_vcpus) still doesn't look to have been fixed in BatchEnvironmentConfig class?

did you see my second response? I realized I specified it this way because this is how it is specified in the cdk library.

See here: https://docs.aws.amazon.com/cdk/api/v2/python/aws_cdk.aws_batch/ManagedEc2EcsComputeEnvironment.html#:~:text=will%20launch%20Instances.-,maxv_cpus,-(Union%5B

@njmei njmei self-requested a review June 5, 2024 16:46
@rpmcginty rpmcginty merged commit 5563f55 into main Jun 5, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants