-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MSPE-391: Adding Demand Execution Constructs to CDK Lib #9
Conversation
src/aibs_informatics_cdk_lib/constructs_/assets/code_asset_definitions.py
Show resolved
Hide resolved
from aibs_informatics_cdk_lib.constructs_.s3 import EnvBaseBucket, LifecycleRuleGenerator | ||
|
||
|
||
class Storage(EnvBaseConstruct): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would we be able to use this construct even for external buckets? Or is this only intended to be used in situations where we are creating (and fully controlling) the s3 bucket(s)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a simple construct and not something we would use in merscope specifically. but I would define the storage aibs s3 bucket and use similar to the buckets specified here.
env_base.get_construct_id(id), | ||
state_machine_name=env_base.get_state_machine_name(name) if name else None, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Under what circumstances would we want to allow state_machine_name
to be None
? Aren't the autogenerated names really hard to track (when we need to track down where the state machine is defined)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, but sometimes we don't care exactly what it is. I am thinking about cases where the state machine will be a nested state machine from which we can find in the top-level named state machine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minv_cpus
(min_vcpus
) still doesn't look to have been fixed in BatchEnvironmentConfig
class?
did you see my second response? I realized I specified it this way because this is how it is specified in the cdk library. |
What's in this Change?
Testing