Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more IAM Actions based on needs for aibs-informatics-workflows. #8

Merged
merged 2 commits into from
May 30, 2024
Merged

Add more IAM Actions based on needs for aibs-informatics-workflows. #8

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0d5e050
Add more IAM Actions based on needs for aibs-informatics-workflows.
sheriferson May 28, 2024
8b8e114
Alphabetize policy actions and improve organization.
sheriferson May 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
79 changes: 79 additions & 0 deletions src/aibs_informatics_cdk_lib/common/aws/iam_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
"""
The list of actions for each service is incomplete and based on our needs so far.
A helpful resource to research actions is:
https://www.awsiamactions.io/
"""

from typing import List, Optional, Union

from aibs_informatics_core.env import EnvBase
Expand Down Expand Up @@ -25,6 +31,25 @@
"batch:*",
]

CLOUDWATCH_READ_ACTIONS = [
"logs:GetLogEvents",
"logs:GetLogRecord",
"logs:GetLogGroupFields",
"logs:GetQueryResults",
"logs:DescribeLogGroups",
]

CLOUDWATCH_WRITE_ACTIONS = [
"logs:CreateLogStream",
"logs:CreateLogGroup",
"logs:PutLogEvents",
]

CLOUDWATCH_FULL_ACCESS_ACTIONS = [
*CLOUDWATCH_READ_ACTIONS,
*CLOUDWATCH_WRITE_ACTIONS,
]

DYNAMODB_READ_ACTIONS = [
"dynamodb:BatchGet*",
"dynamodb:DescribeStream",
Expand All @@ -50,6 +75,26 @@

EC2_ACTIONS = ["ec2:DescribeAvailabilityZones"]

ECS_READ_ACTIONS = [
"ecs:DescribeTaskDefinition",
"ecs:ListTasks",
"ecs:DescribeTasks",
]

ECS_WRITE_ACTIONS = [
"ecs:RegisterTaskDefinition",
]

ECS_RUN_ACTIONS = [
"ecs:RunTask",
]

ECS_FULL_ACCESS_ACTIONS = [
*ECS_READ_ACTIONS,
*ECS_WRITE_ACTIONS,
*ECS_RUN_ACTIONS,
]

ECR_READ_ACTIONS = [
"ecr:GetAuthorizationToken",
"ecr:BatchCheckLayerAvailability",
Expand Down Expand Up @@ -78,6 +123,23 @@
"ecr:UntagResource",
]


KMS_READ_ACTIONS = [
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add constants in alphabetical order?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand that not everything is ordered alphabetically, but it would be helpful if you tried to order. even better if you ordered others by alphabet and type of constant (action lists vs policy variables)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried to alphabetize and reorganize the file. Let me know if that does what you were requesting.

"kms:Decrypt",
"kms:DescribeKey",
]

KMS_WRITE_ACTIONS = [
"kms:GenerateDataKey*",
"kms:Encrypt",
"kms:PutKeyPolicy",
]

KMS_FULL_ACCESS_ACTIONS = [
*KMS_READ_ACTIONS,
*KMS_WRITE_ACTIONS,
]

ECR_FULL_ACCESS_ACTIONS = [*ECR_READ_ACTIONS, *ECR_WRITE_ACTIONS, *ECR_TAGGING_ACTIONS]

ECS_READ_ACTIONS = ["ecs:DescribeContainerInstances"]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will override what you have specified above

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack, thanks for catching that. Perfect example of why alphabetization helps.

Expand Down Expand Up @@ -122,6 +184,23 @@

SNS_FULL_ACCESS_ACTIONS = ["sns:*"]

SQS_READ_ACTIONS = [
"sqs:GetQueueAttributes",
"sqs:GetQueueUrl",
"sqs:ReceiveMessage",
"sqs:SendMessage",
]

SQS_WRITE_ACTIONS = [
"sqs:ChangeMessageVisibility",
"sqs:DeleteMessage",
]

SQS_FULL_ACCESS_ACTIONS = [
*SQS_READ_ACTIONS,
*SQS_WRITE_ACTIONS,
]

SSM_READ_ACTIONS = [
"ssm:GetParameter",
"ssm:GetParameters",
Expand Down
Loading