Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have aibs-informatics-cdk-lib pkg indicate that it is typed #4

Merged
merged 1 commit into from
May 16, 2024

Conversation

njmei
Copy link
Collaborator

@njmei njmei commented May 16, 2024

Currently, due to a missing py.typed file, this package will will raise mypy typing errors when used as a dependency in some other package.

This commit fixes this issue by adding the missing file and updating the pyproject.toml to include the py.typed file as part of package_data.

For details see:
https://mypy.readthedocs.io/en/stable/installed_packages.html#creating-pep-561-compatible-packages

Currently, due to a missing `py.typed` file, this package will
will raise mypy typing errors when used as a dependency in
some other package.

This commit fixes this issue by adding the missing file and
updating the `pyproject.toml` to include the `py.typed` file
as part of `package_data`.

For details see:
https://mypy.readthedocs.io/en/stable/installed_packages.html#creating-pep-561-compatible-packages
@njmei njmei requested a review from rpmcginty May 16, 2024 18:17
@njmei njmei merged commit 32a73f6 into main May 16, 2024
4 checks passed
@njmei njmei deleted the fix-pkg-typing branch May 16, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants