Cleanup of BatchLaunchTemplate + make External SNS trigger configurable #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sheriferson
approved these changes
Nov 20, 2024
Comment on lines
117
to
119
| enabled=(env_base.env_type is EnvType.PROD) | ||
| if sqs_event_source_enabled is None | ||
| else sqs_event_source_enabled, |
There was a problem hiding this comment.
Super-nit, but maybe the order of priority is clearer if written as:
enabled=sqs_event_source_enabled
if sqs_event_event_source_enabled
else (env_base.env_type is EnvType.PROD)| @@ -71,7 +82,7 @@ def __init__( | |||
| scope=self, | |||
| id=env_base.get_construct_id(external_sns_event_name, "sns-event-queue"), | |||
| queue_name=env_base.prefixed(external_sns_event_name, "sns-event-queue"), | |||
| retention_period=cdk.Duration.days(7), | |||
| retention_period=external_sns_event_queue_retention_period or cdk.Duration.days(7), | |||
There was a problem hiding this comment.
Could set the default for external_sns_event_queue_retention_period to cdk.Duration.days(7) in the signature and simplify this line to:
retention_period=external_sns_event_queue_retention_period,?
njmei
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this Change?
abstractmethodwhere it should not be. discovered in this run https://github.com/AllenInstitute/merscope-analysis-cloud-pipeline/actions/runs/11940809177/job/33284283001?pr=62