Update aibs-informatics-cdk-lib dependencies #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates our aws-cdk-lib dependency to at least v2.96 which made the `aws_batch` module stable. As a result, the `aws-cdk.aws-batch-alpha` package is no longer necessary. See: https://github.com/aws/aws-cdk/releases/tag/v2.96.0
This tool is not actively being used and is in fact not compatible with the stable version of `aws_batch` in `aws-cdk-lib` so this commit removes it.
1. Prefer BEST_FIT over BEST_FIT_PROGRESSIVE 2. Prefer SPOT_PRICE_CAPACITY_OPTIMIZED for `use_spot=True` configs
rpmcginty
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Porting over changes made in OCS:
https://github.com/AllenInstitute/genomics-cloud-services/pull/811
https://github.com/AllenInstitute/genomics-cloud-services/commit/d43cda61181267c3354273a7c549700bf61fe1c3
Key changes summary:
aws-cdk-libto at least v2.96 and dropaws-cdk.aws-batch-alphadependencyallocation strategiesfor batch environment configs