Add "env_label" override to BaseProjectConfig.get_stage_config
#15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rpmcginty
reviewed
Jul 16, 2024
| default_config = create_stage_config() | ||
|
|
||
| default_config_overrides = { | ||
| EnvType.DEV: { |
There was a problem hiding this comment.
But this is a nested mapping with the key as env type, so adding this capability seems unnecessary, right? Or is this just an env label override
When wanting to deploy stages outside of a CodePipeline context there will still be a need to provide a `env_label`.
njmei
force-pushed
the
fix-get-stage-config
branch
from
aadc219 to
a911049
Compare
rpmcginty
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When wanting to deploy stages outside of a CodePipeline context there will still be a need to provide a
env_label.For additional context for why this is needed see the second commit for:
https://github.com/AllenInstitute/merscope-analysis-cloud-pipeline/pull/30