feature/update cicd pipeline stack base class #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
njmei
reviewed
Jul 11, 2024
njmei
reviewed
Jul 11, 2024
Comment on lines
360
to
364
| # Steps: | ||
| # 1. Read the release script file | ||
| # 2. Base64 encode the file | ||
| # 3. Decode the base64 encoded file and write it to the release script path | ||
| f"echo {base64.b64encode((Path(__file__).parent / 'scripts' / 'cicd-release.sh').read_text().encode()).decode()} | base64 --decode > $RELEASE_SCRIPT_PATH" |
There was a problem hiding this comment.
Are there any size limitations for this method?
There was a problem hiding this comment.
I don't know unfortunately. I am trying to test these two options out to see what is best. I would assume for our script, it is small enough but I will know definitively soon.
There was a problem hiding this comment.
I will need to pick an option once my tests are complete.
njmei
reviewed
Jul 11, 2024
| create_pull_request_step = pipelines.CodeBuildStep( | ||
| "CreateReleasePullRequest", | ||
| input=self.get_pipeline_source(pipeline_config.source), | ||
| # Environment needs to have privelaged access |
There was a problem hiding this comment.
I know this is old code, but might be good to go into more depth about what aspect of the build needs the privileged access and why it's needed rather than just stating it is necessary.
njmei
reviewed
Jul 11, 2024
njmei
reviewed
Jul 11, 2024
njmei
reviewed
Jul 11, 2024
rpmcginty
force-pushed
the
feature/update-cicd-pipeline-stack-base-class
branch
2 times, most recently
from
47ac51f to
8c255fa
Compare
rpmcginty
force-pushed
the
feature/update-cicd-pipeline-stack-base-class
branch
from
8c255fa to
4da2eca
Compare
njmei
reviewed
Jul 12, 2024
njmei
reviewed
Jul 12, 2024
njmei
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this Change?
improving base pipeline stack
pipeline_stagedecorator and more fleshed out functionality in base stackTesting