Add CI/CD Pipeline Stack Base Class #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
njmei
reviewed
Jul 3, 2024
Comment on lines
141
to
153
| # TEMPORARY -- we need to use this going forward | ||
| # source = pipelines.CodePipelineSource.connection( | ||
| # repo_string=github_config.repository, | ||
| # branch=github_config.branch, | ||
| # connection_arn=build_arn( | ||
| # service="codestar-connections", | ||
| # resource_type="connection", | ||
| # resource_delim="/", | ||
| # resource_id=github_config.codestar_connection, | ||
| # ), | ||
| # code_build_clone_output=True, | ||
| # trigger_on_push=True, | ||
| # ) |
There was a problem hiding this comment.
This might be an opportunity to switch to codestar connection instead of legacy github connection? Or would you want to tackle this in separate work?
There was a problem hiding this comment.
I have made either option usable based on the presence of the fields in the source config.
njmei
reviewed
Jul 3, 2024
Comment on lines
+29
to
+35
| BaseProjectConfig, | ||
| CodePipelineSourceConfig, | ||
| Env, | ||
| GlobalConfig, | ||
| PipelineConfig, | ||
| ProjectConfig, | ||
| StageConfig, |
There was a problem hiding this comment.
Might be useful if you can add some example values for what the fields in these config dataclasses should look like. At least at a glance, I wasn't sure about the differences between all these different config types and where/how they are supposed to be used.
njmei
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this Change?
Adding a new pipeline stack base class. Will use in project applications