Add external SNS topic trigger stack #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
njmei
force-pushed
the
add-external-sns-trigger-stack
branch
4 times, most recently
from
c9ac77e to
3cb07cf
Compare
rpmcginty
reviewed
May 6, 2024
Comment on lines
111
to
124
| self.triggered_lambda_dlq_alarm = cloudwatch.Alarm( | ||
| scope=self, | ||
| id=self.get_construct_id(triggered_lambda_fn_name, "dlq", "alarm"), | ||
| alarm_description=( | ||
| f"Alarm if more than 1 message in {triggered_lambda_dlq_name} in 10 minute period" | ||
| ), | ||
| metric=self.triggered_lambda_dlq.metric_approximate_number_of_messages_visible( | ||
| statistic=cloudwatch.Stats.MAXIMUM, | ||
| period=cdk.Duration.minutes(10), | ||
| ), | ||
| evaluation_periods=1, | ||
| threshold=1, | ||
| datapoints_to_alarm=1, | ||
| comparison_operator=cloudwatch.ComparisonOperator.GREATER_THAN_OR_EQUAL_TO_THRESHOLD, |
There was a problem hiding this comment.
wonder if this should be configurable as well.
njmei
force-pushed
the
add-external-sns-trigger-stack
branch
from
3cb07cf to
be540ae
Compare
njmei
changed the title
rpmcginty
approved these changes
Jul 19, 2024
| ) | ||
| self.external_sns_event_queue.grant_consume_messages(triggered_lambda_fn) | ||
|
|
||
| # Alarm that fires if external_sns_event_queue fails delivery or if lambda fails to process |
There was a problem hiding this comment.
I had a comment before about making this configurable. could you add a todo maybe if not make it configurable this go around?
There was a problem hiding this comment.
Got it, will add a TODO comment
njmei
force-pushed
the
add-external-sns-trigger-stack
branch
from
be540ae to
5c7a61a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a stack template for subscribing to an external SNS topic (in another AWS account) and triggering a lambda within the deploying AWS account.
This is expected to be useful in the future if we want to create additional triggers from PTS SNS topics or from other SNS topics.